-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multimodal heading and Document question answering in task_summary.mdx #23318
Add Multimodal heading and Document question answering in task_summary.mdx #23318
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice - thanks for adding!
@y3sar - The current CI tests are failing because this PR triggers tests checking code snippets in the docs, and the doctest CI environment doesn't have ffmpeg installed. I've opened a PR #23329 to resolve this. Once I've confirmed everything works, we can re-run for this PR and if all green then merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again for your contribution and for adding the new multimodal section! 🤗
@y3sar Sorry for the delay in this. There's been a lot of changes in how doctests are retrieved and run. Could you rebase onto main to get the latest updates? |
@amyeroberts sure thing I'll rebase and commit again |
@y3sar Did you force push after rebasing the branch? The current commit history looks like what I get if I push but don't force. |
@amyeroberts no I did not force push. I rebased and pull pushed. What should I do to solve this problem? |
@y3sar To rebase onto main you need to force push, as rebasing is a form of history rewrite. The steps are - running on this branch:
|
32d0e00
to
87831bf
Compare
@amyeroberts ffmpeg bug still remains. What can I do to solve this? |
@amyeroberts should I commit in this branch or should I create another pull request? |
@y3sar Commit on this branch :) |
87831bf
to
10c08ac
Compare
@y3sar Apologies for the delay with this PR. Could you rebase again and push. We've been having issues with timeouts on the CI which should now be resolved. Additionally, could you update the extension for the |
@amyeroberts thank you for remembering this pull request 😄😄😄🙏 |
10c08ac
to
e7433c4
Compare
@amyeroberts looks like the timeout issue remains. Should I change the code example? |
@y3sar Let's draft in help from the king of tests @ydshieh :) I did a test run of this example on a CPU and it took 40s, so not fats but not super slow either. I think we could try:
|
Let me see what's happening on the CI runner. |
Hi, I checked. That I can change the environment variable to avoid this situation. Once that change is merged, you can rebase and the CI should be green. |
The PR is opened |
That PR is merged into |
e7433c4
to
efd6e39
Compare
Thank you the king of tests and @amyeroberts. Should I check for a smaller checkpoint? |
It would be always great to use a small(er) checkpoint for testing (if there is any) 🙏 Thank you @y3sar |
@ydshieh @amyeroberts I have found some small(er) models. The model that is being used currently is 803 mb. I have found a checkpoint that is 500 mb. Which is still very big but smaller. And also I have found an even smaller checkpoint that is used for testing by the huggingface internals. But the results are not that reliable. |
@y3sar Thanks for looking into this! The tiny models are just for internal testing and probably not something we want to have in the docs (we want to be able to adapt to our needs without considering breaking changes). I'd say go for the 500MB one :) |
efd6e39
to
98ac868
Compare
@y3sar Thanks again for iterating and adding this! |
What does this PR do?
From #18926
This PR creates a new Multimodal heading in task_summary and add Document question answering task example inside of it.
Who can review?
@stevhliu