Add document-question-answering in task_summary #23252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
y3sar
force-pushed
the
add-docqa-example-to-task_summary
branch
from
c735c4e to
396e031
Compare
|
@stevhliu I only changed the docs. I don't know why the checks keep failing. It says it is having problems with ffmpeg? |
* fix gpt2 inference * fixup * no need to be in `_keys_to_ignore_on_load_missing`
…ace#23257) * Temp tol fix for flaky whipser test * Add equivalent update to TF tests
…uggingface#22787) * update min k_value of conditional detr post-processing * feat: add top_k arg to post processing of deformable and conditional detr * refactor: revert changes to deprecated methods * refactor: move prob reshape to improve code clarity and reduce repetition
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
stevhliu
reviewed
May 11, 2023
There was a problem hiding this comment.
I left a suggestion to simplify the multimodal section a bit and to break up the text so it is more readable. Otherwise, looks good to me!
Looks like your merge may have introduced some other changes. I think maybe closing this and opening a new PR would the easiest here? What do you recommend @amyeroberts?
|
Thank you so much for you help @stevhliu I think I should open a new PR. I made a mess here |
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
|
I created a new pull request #23318 closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
From issue #18926
This PR adds Document Question Answering summary to task_summary.mdx
It also provides an example using pipeline and this model
Who can review?
@stevhliu