-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependencies in worker to support first rows from parquet #996
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Weird but some tests for parquet-and-dataset-info job runner are failing, it looks like it is caused by pyarrow 11. I will investigate locally. |
CSV_PARQUET_SIZE = 1_865 | ||
AUDIO_PARQUET_SIZE = 1_383 | ||
CSV_PARQUET_SIZE = 1_866 | ||
AUDIO_PARQUET_SIZE = 1_384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing size to have test running successful. Looks like pyarrow 11 increased the size of computed parquet file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks!
@@ -328,7 +328,7 @@ def create_dataset_info_response_for_csv(dataset: str, config: str) -> Any: | |||
} | |||
|
|||
|
|||
def create_dataset_info_response_for_audio(dataset: str, config: str) -> Any: | |||
def create_dataset_info_response_for_audio() -> Any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this little refactor to make git actions alive again on this PR, nothing related to the logic.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 89.58% 91.55% +1.96%
==========================================
Files 147 53 -94
Lines 7854 3740 -4114
==========================================
- Hits 7036 3424 -3612
+ Misses 818 316 -502
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 94 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Preparation for #988 implementation
As suggested in #988 (comment)
I followed these steps: