-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split first rows from parquet new Job Runner #988
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
- Coverage 89.58% 87.81% -1.77%
==========================================
Files 147 94 -53
Lines 7854 4121 -3733
==========================================
- Hits 7036 3619 -3417
+ Misses 818 502 -316
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 53 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The documentation is not available anymore as the PR was closed or merged. |
208598f
to
3cb300d
Compare
Not sure why pip audit fails with worker project, it is now different from other folders that use
|
In 12289d8, you updated all the dependencies of the project, including some that were not related to the matter of this PR. It's better to do it in a separate PR, where we update the dependencies and ensure nothing has broken. In this case, you updated the dev dependency So, my recommendation for this PR would be to:
and I think that your poetry.lock should be good (in particular, you should be using pip-audit v2.4.14) And then, in another PR, we could upgrade the dependencies, one by one, and checking that we don't break anything. |
0e87d4f
to
b2f428b
Compare
I introduced dependencies for this PR on #996 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. This, along with #995, should help reduce a lot the load on the workers!
I will introduce same logic as #995 for first rows job runners |
You're right, #995 was for split-names. Let's do it for first-rows now! |
Final part of #755
Based on #875 for parquet reading logic