feat: 🎸 add logs when an unexpected error occurs

services/admin/src/admin/routes/backfill.py

@@ -54,7 +54,7 @@ async def backfill_endpoint(request: Request) -> Response:
             )
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=0)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=0)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=0)
 
     return backfill_endpoint

services/admin/src/admin/routes/cache_reports.py

@@ -46,7 +46,7 @@ async def cache_reports_endpoint(request: Request) -> Response:
                 ) from e
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=max_age)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=max_age)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=max_age)
 
     return cache_reports_endpoint

services/admin/src/admin/routes/cache_reports_with_content.py

@@ -52,7 +52,7 @@ async def cache_reports_with_content_endpoint(request: Request) -> Response:
                 ) from e
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=max_age)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=max_age)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=max_age)
 
     return cache_reports_with_content_endpoint

services/admin/src/admin/routes/cancel_jobs.py

@@ -37,7 +37,7 @@ async def cancel_jobs_endpoint(request: Request) -> Response:
             )
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=0)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=0)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=0)
 
     return cancel_jobs_endpoint

services/admin/src/admin/routes/force_refresh.py

@@ -61,7 +61,7 @@ async def force_refresh_endpoint(request: Request) -> Response:
             )
         except (DatasetError, AdminCustomError) as e:
             return get_json_admin_error_response(e, max_age=0)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=0)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=0)
 
     return force_refresh_endpoint

services/admin/src/admin/routes/jobs_duration.py

@@ -36,7 +36,7 @@ async def jobs_duration_per_dataset_endpoint(request: Request) -> Response:
             )
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=max_age)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=max_age)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=max_age)
 
     return jobs_duration_per_dataset_endpoint

services/admin/src/admin/routes/pending_jobs.py

@@ -39,7 +39,7 @@ async def pending_jobs_endpoint(request: Request) -> Response:
             )
         except AdminCustomError as e:
             return get_json_admin_error_response(e, max_age=max_age)
-        except Exception:
-            return get_json_admin_error_response(UnexpectedError("Unexpected error."), max_age=max_age)
+        except Exception as e:
+            return get_json_admin_error_response(UnexpectedError("Unexpected error.", e), max_age=max_age)
 
     return pending_jobs_endpoint

services/admin/src/admin/utils.py

@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: Apache-2.0
 # Copyright 2022 The HuggingFace Authors.
 
+import logging
 from http import HTTPStatus
 from typing import Any, Callable, Coroutine, List, Literal, Optional
 
@@ -57,8 +58,12 @@ def __init__(self, message: str):
 class UnexpectedError(AdminCustomError):
     """Raised when an unexpected error occurred."""
 
-    def __init__(self, message: str):
-        super().__init__(message, HTTPStatus.INTERNAL_SERVER_ERROR, "UnexpectedError")
+    def __init__(self, message: str, cause: Optional[BaseException] = None):
+        super().__init__(message, HTTPStatus.INTERNAL_SERVER_ERROR, "UnexpectedError", cause)
+        if cause:
+            logging.exception(message, exc_info=cause)
+        else:
+            logging.exception(message)
 
 
 class ExternalUnauthenticatedError(AdminCustomError):

services/api/src/api/routes/valid.py

@@ -56,8 +56,8 @@ async def valid_endpoint(_: Request) -> Response:
             logging.info("/valid")
             content = {"valid": get_valid(processing_steps_for_valid=processing_steps_for_valid)}
             return get_json_ok_response(content, max_age=max_age_long)
-        except Exception:
-            return get_json_api_error_response(UnexpectedError("Unexpected error."), max_age=max_age_short)
+        except Exception as e:
+            return get_json_api_error_response(UnexpectedError("Unexpected error.", e), max_age=max_age_short)
 
     return valid_endpoint
 
@@ -83,7 +83,7 @@ async def is_valid_endpoint(request: Request) -> Response:
             return get_json_ok_response(content=content, max_age=max_age_long)
         except ApiCustomError as e:
             return get_json_api_error_response(error=e, max_age=max_age_short)
-        except Exception:
-            return get_json_api_error_response(error=UnexpectedError("Unexpected error."), max_age=max_age_short)
+        except Exception as e:
+            return get_json_api_error_response(error=UnexpectedError("Unexpected error.", e), max_age=max_age_short)
 
     return is_valid_endpoint

services/api/src/api/routes/webhook.py

@@ -106,7 +106,8 @@ async def webhook_endpoint(request: Request) -> Response:
         except ValidationError:
             content = {"status": "error", "error": "the JSON payload is invalid"}
             return get_response(content, 400)
-        except Exception:
+        except Exception as e:
+            logging.exception("Unexpected error", exc_info=e)
             content = {"status": "error", "error": "unexpected error"}
             return get_response(content, 500)
 

services/api/src/api/utils.py

@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: Apache-2.0
 # Copyright 2022 The HuggingFace Authors.
 
+import logging
 from http import HTTPStatus
 from typing import Any, Callable, Coroutine, List, Literal, Optional
 
@@ -59,6 +60,10 @@ class UnexpectedError(ApiCustomError):
 
     def __init__(self, message: str, cause: Optional[BaseException] = None):
         super().__init__(message, HTTPStatus.INTERNAL_SERVER_ERROR, "UnexpectedError", cause)
+        if cause:
+            logging.exception(message, exc_info=cause)
+        else:
+            logging.exception(message)
 
 
 class ExternalUnauthenticatedError(ApiCustomError):

workers/datasets_based/src/datasets_based/worker.py

@@ -105,7 +105,7 @@ def __init__(self, message: str, cause: Optional[BaseException] = None):
 
 
 class UnexpectedError(GeneralWorkerError):
-    """Raised when the response for the split has not been found."""
+    """Raised when the worker raised an unexpected error."""
 
     def __init__(self, message: str, cause: Optional[BaseException] = None):
         super().__init__(
@@ -115,6 +115,10 @@ def __init__(self, message: str, cause: Optional[BaseException] = None):
             cause=cause,
             disclose_cause=False,
         )
+        if cause is not None:
+            logging.exception(message, exc_info=cause)
+        else:
+            logging.exception(message)
 
 
 class Worker(ABC):