Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add logs when an unexpected error occurs #789

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 8, 2023

No description provided.

@HuggingFaceDocBuilder
Copy link
Collaborator

HuggingFaceDocBuilder commented Feb 8, 2023

The documentation is not available anymore as the PR was closed or merged.

@severo severo changed the title feat: 🎸 add logs when an unexcepted error occurs feat: 🎸 add logs when an unexpected error occurs Feb 8, 2023
Copy link
Contributor

@AndreaFrancis AndreaFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor observation

services/admin/src/admin/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Andrea Soria Jimenez <andrea@huggingface.co>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 89.77% // Head: 90.62% // Increases project coverage by +0.84% 🎉

Coverage data is based on head (95422b0) compared to base (4ce5333).
Patch coverage: 15.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   89.77%   90.62%   +0.84%     
==========================================
  Files          84       70      -14     
  Lines        3904     3497     -407     
==========================================
- Hits         3505     3169     -336     
+ Misses        399      328      -71     
Flag Coverage Δ
jobs_mongodb_migration ?
services_admin 86.74% <10.00%> (-0.38%) ⬇️
services_api 89.53% <10.00%> (-0.61%) ⬇️
workers_datasets_based 92.04% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/admin/src/admin/routes/backfill.py 56.52% <0.00%> (ø)
services/admin/src/admin/routes/cache_reports.py 84.00% <0.00%> (ø)
...min/src/admin/routes/cache_reports_with_content.py 84.00% <0.00%> (ø)
services/admin/src/admin/routes/cancel_jobs.py 55.00% <0.00%> (ø)
services/admin/src/admin/routes/force_refresh.py 62.16% <0.00%> (ø)
services/admin/src/admin/routes/jobs_duration.py 57.89% <0.00%> (ø)
services/admin/src/admin/routes/pending_jobs.py 78.94% <0.00%> (ø)
services/api/src/api/routes/valid.py 88.37% <0.00%> (ø)
services/api/src/api/routes/webhook.py 64.51% <0.00%> (-1.06%) ⬇️
services/api/src/api/utils.py 88.88% <25.00%> (-5.12%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we can get more insights this way...

services/api/src/api/utils.py Outdated Show resolved Hide resolved
workers/datasets_based/src/datasets_based/worker.py Outdated Show resolved Hide resolved
services/admin/src/admin/routes/backfill.py Show resolved Hide resolved
severo and others added 2 commits February 8, 2023 15:28
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
@severo severo merged commit 3ca72c6 into main Feb 8, 2023
@severo severo deleted the add-logs branch February 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants