Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks on Helm charts #649

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Small tweaks on Helm charts #649

merged 3 commits into from
Jan 2, 2023

Conversation

n1t0
Copy link
Member

@n1t0 n1t0 commented Nov 28, 2022

  • Ignore env files in packaged charts
  • Add ability to completely specify ingress.tls
  • Automatic value for token.secretName if not specified
  • Do not submit mongodb-migration job if image not specified
  • Add ability to specify imagePullPolicy

@n1t0 n1t0 requested review from severo and XciD November 28, 2022 12:43
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two questions

chart/templates/ingress.yaml Show resolved Hide resolved
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 87.92% // Head: 89.50% // Increases project coverage by +1.57% 🎉

Coverage data is based on head (7325e9d) compared to base (e31129e).
Patch has no changes to coverable lines.

❗ Current head 7325e9d differs from pull request most recent head c18120f. Consider uploading reports for the commit c18120f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   87.92%   89.50%   +1.57%     
==========================================
  Files          48       86      +38     
  Lines        1623     4239    +2616     
==========================================
+ Hits         1427     3794    +2367     
- Misses        196      445     +249     
Flag Coverage Δ
jobs_mongodb_migration 84.33% <ø> (ø)
libs_libcommon 88.04% <ø> (?)
services_admin 88.85% <ø> (ø)
services_api 89.91% <ø> (ø)
workers_datasets_based 92.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tasets_based/src/datasets_based/workers/parquet.py 91.66% <0.00%> (ø)
libs/libcommon/src/libcommon/queue.py 95.52% <0.00%> (ø)
libs/libcommon/tests/test_storage.py 81.81% <0.00%> (ø)
libs/libcommon/src/libcommon/config.py 81.31% <0.00%> (ø)
libs/libcommon/tests/test_simple_cache.py 100.00% <0.00%> (ø)
libs/libcommon/tests/test_queue.py 100.00% <0.00%> (ø)
...rkers/datasets_based/tests/workers/test_parquet.py 100.00% <0.00%> (ø)
libs/libcommon/src/libcommon/processing_graph.py 95.00% <0.00%> (ø)
libs/libcommon/src/libcommon/worker.py 79.71% <0.00%> (ø)
workers/datasets_based/tests/fixtures/hub.py 97.79% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo
Copy link
Collaborator

severo commented Jan 2, 2023

Thanks @n1t0!

@severo severo merged commit 9bdd3f0 into main Jan 2, 2023
@severo severo deleted the helm-tweaks branch January 2, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants