chore: 🤖 move value to "docker" since dockerImage is overridden

See Makefile
huggingface · Jan 2, 2023 · c18120f · c18120f
1 parent 7325e9d
commit c18120f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/chart/templates/worker/first-rows/_container.tpl b/chart/templates/worker/first-rows/_container.tpl
@@ -4,7 +4,7 @@
 {{- define "containerWorkerFirstRows" -}}
 - name: "{{ include "name" . }}-worker-first-rows"
   image: {{ .Values.dockerImage.workers.datasets_based }}
-  imagePullPolicy: IfNotPresent
+  imagePullPolicy: {{ .Values.docker.pullPolicy }}
   env:
   - name: DATASETS_BASED_ENDPOINT
     value: "/first-rows"

diff --git a/chart/templates/worker/parquet/_container.tpl b/chart/templates/worker/parquet/_container.tpl
@@ -4,7 +4,7 @@
 {{- define "containerWorkerParquet" -}}
 - name: "{{ include "name" . }}-worker-parquet"
   image: {{ .Values.dockerImage.workers.datasets_based }}
-  imagePullPolicy: IfNotPresent
+  imagePullPolicy: {{ .Values.docker.pullPolicy }}
   env:
   - name: DATASETS_BASED_ENDPOINT
     value: "/parquet"

diff --git a/chart/templates/worker/splits/_container.tpl b/chart/templates/worker/splits/_container.tpl
@@ -4,7 +4,7 @@
 {{- define "containerWorkerSplits" -}}
 - name: "{{ include "name" . }}-worker-splits"
   image: {{ .Values.dockerImage.workers.datasets_based }}
-  imagePullPolicy: {{ .Values.dockerImage.pullPolicy }}
+  imagePullPolicy: {{ .Values.docker.pullPolicy }}
   env:
   - name: DATASETS_BASED_ENDPOINT
     value: "/splits"

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -37,9 +37,11 @@ mongodb:
 
 imagePullSecrets: []
 
-# overridden by docker-images.yaml (which must be in JSON format!)
-dockerImage:
+docker:
   pullPolicy: IfNotPresent
+
+# overridden by docker-images.yaml (which must be in JSON format!). See Makefile for details.
+dockerImage:
   reverseProxy: ""
   jobs:
     mongodb_migration: ""