Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics #258

Merged
merged 13 commits into from
May 13, 2022
Merged

Add metrics #258

merged 13 commits into from
May 13, 2022

Commits on May 12, 2022

  1. fix: 🐛 remove EXPOSE since the port will depend on an env var 

    It does not make sense to expose a port at build time if the port will
be defined at execution time. See
https://docs.docker.com/engine/reference/run/#expose-incoming-ports
    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    c5d55b5 View commit details
    Browse the repository at this point in the history

  2. feat: 🎸 add an endpoint for the prometheus metrics

    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    59146d6 View commit details
    Browse the repository at this point in the history

  3. feat: 🎸 add a metrics endpoint 

    BREAKING CHANGE: 🧨 environment variables have changed
    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    8ba2427 View commit details
    Browse the repository at this point in the history

  4. feat: 🎸 use the new env vars format in Kube

    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    8bb0150 View commit details
    Browse the repository at this point in the history

  5. fix: 🐛 move the metrics into the API as /metrics 

    It makes no sense to have it in a parallel application.
    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    eea6c56 View commit details
    Browse the repository at this point in the history

  6. feat: 🎸 rename api to app

    @severo
    severo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    060886f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. feat: 🎸 create the /metrics endpoint and remove /queue 

    The queue information is now available as Prometheus metrics in /metrics
    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a117dee View commit details
    Browse the repository at this point in the history

  2. feat: 🎸 add cache metrics, and remove /cache endpoint

    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    cbe9a4f View commit details
    Browse the repository at this point in the history

  3. test: 💍 fix tests

    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a94bdb5 View commit details
    Browse the repository at this point in the history

  4. feat: 🎸 rename /metrics in /prometheus 

    It's clearer, and it will allow to provide info about the dataset
metrics (https://huggingface.co/metrics) if needed. Also: fix tests
    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e72d673 View commit details
    Browse the repository at this point in the history

  5. docs: ✏️ update the readme

    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    5bc55eb View commit details
    Browse the repository at this point in the history

  6. test: 💍 launch mongo before the tests

    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e7f190f View commit details
    Browse the repository at this point in the history

  7. test: 💍 fix tests 

    (and style)
    @severo
    severo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    3781fc8 View commit details
    Browse the repository at this point in the history