Add metrics #258
Merged
Add metrics #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to expose a port at build time if the port will be defined at execution time. See https://docs.docker.com/engine/reference/run/#expose-incoming-ports
BREAKING CHANGE: 🧨 environment variables have changed
It makes no sense to have it in a parallel application.
The queue information is now available as Prometheus metrics in /metrics
It's clearer, and it will allow to provide info about the dataset metrics (https://huggingface.co/metrics) if needed. Also: fix tests
(and style)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.