Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 update the OpenAPI spec #1667

Merged
merged 10 commits into from
Aug 11, 2023
Merged

fix: 🐛 update the OpenAPI spec #1667

merged 10 commits into from
Aug 11, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Aug 10, 2023

Missing:

In other PRs:

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.03% 🎉

Comparison is base (8cf6784) 90.35% compared to head (f67c74b) 90.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
+ Coverage   90.35%   90.38%   +0.03%     
==========================================
  Files         204      208       +4     
  Lines       12636    12744     +108     
==========================================
+ Hits        11417    11519     +102     
- Misses       1219     1225       +6     
Flag Coverage Δ
jobs_cache_maintenance 99.47% <100.00%> (+0.09%) ⬆️
jobs_mongodb_migration 85.10% <87.80%> (+0.03%) ⬆️
libs_libcommon 91.69% <98.33%> (+0.06%) ⬆️
services_admin 86.76% <ø> (ø)
services_api 88.30% <ø> (ø)
services_rows 82.96% <100.00%> (+0.03%) ⬆️
services_search 78.76% <ø> (ø)
services_worker 92.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
libs/libcommon/src/libcommon/exceptions.py 68.78% <ø> (ø)
libs/libcommon/src/libcommon/metrics.py 100.00% <ø> (ø)
...tests/job_runners/config/test_config_job_runner.py 86.36% <ø> (-1.14%) ⬇️
...sts/job_runners/dataset/test_dataset_job_runner.py 86.36% <ø> (-1.14%) ⬇️
...r/tests/job_runners/split/test_split_job_runner.py 86.95% <ø> (-1.05%) ⬇️
...s/_20230811063600_cache_metrics_drop_collection.py 70.58% <70.58%> (ø)
libs/libcommon/src/libcommon/simple_cache.py 91.06% <96.87%> (+0.64%) ⬆️
...maintenance/src/cache_maintenance/cache_metrics.py 100.00% <100.00%> (ø)
...maintenance/src/cache_maintenance/queue_metrics.py 100.00% <100.00%> (ø)
...he_maintenance/tests/test_collect_cache_metrics.py 100.00% <100.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 11, 2023

The documentation is not available anymore as the PR was closed or merged.

@severo severo force-pushed the fix-openapi branch 4 times, most recently from 72a15d9 to 2c83386 Compare August 11, 2023 17:51
here: the error is on the server, so: changing it to 500.

by the way, we don't have any error of this kind in the cache, which is
good since it would reveal a bug in the code.
@severo severo marked this pull request as ready for review August 11, 2023 19:09
@@ -136,7 +147,10 @@ class ConfigSize(TypedDict):
num_columns: int


class SplitSize(SplitItem):
class SplitSize(TypedDict):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to FullSplitItem instead of TypedDict?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it could be. But I found that a lot of indirections are not easy to follow. Easier to just put the four properties

@severo severo merged commit 7e53189 into main Aug 11, 2023
22 checks passed
@severo severo deleted the fix-openapi branch August 11, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants