Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gated datasets without authentication header return 404 #1656

Open
severo opened this issue Aug 9, 2023 · 1 comment
Open

Gated datasets without authentication header return 404 #1656

severo opened this issue Aug 9, 2023 · 1 comment
Labels
bug Something isn't working P2 Nice to have

Comments

@severo
Copy link
Collaborator

severo commented Aug 9, 2023

It should return 401 (Unauthorized).

See for example https://datasets-server.huggingface.co/splits?dataset=severo/bigcode/the-stack from a private window.

Or https://datasets-server.huggingface.co/splits?dataset=JosephusCheung/GuanacoDataset (if you have not access to it), while passing credentials (opening it while logged in Hugging Face will pass your cookie)

@severo severo added bug Something isn't working P2 Nice to have labels Aug 9, 2023
@severo
Copy link
Collaborator Author

severo commented Aug 11, 2023

When processing this issue, try to also test authenticated against authorized, and add examples in the openapi spec if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Nice to have
Projects
None yet
Development

No branches or pull requests

1 participant