Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse-proxy is not reloaded if nginx template is modified #369

Closed
severo opened this issue Jun 10, 2022 · 3 comments
Closed

reverse-proxy is not reloaded if nginx template is modified #369

severo opened this issue Jun 10, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@severo
Copy link
Collaborator

severo commented Jun 10, 2022

If the nginx template config is modified, it's correctly mounted in the pod, you can check with:

$ k exec -it datasets-server-prod-reverse-proxy-64478c4f6b-fhjsx -- sh
# more /etc/nginx/templates/default.conf.template

But I don't think the nginx process is reloaded, and I don't see a way to easily check if it is or not (https://serverfault.com/a/361465/363977 is too hardcore, and gdb is not installed on the pod)
@severo severo added question Further information is requested infra labels Jun 10, 2022
@severo
Copy link
Collaborator Author

severo commented Jun 10, 2022

do you have an idea @XciD? (not urgent)

@XciD
Copy link
Member

XciD commented Jun 13, 2022

You need to use something like this:
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

to re-trigger the deployment

@severo severo added good first issue Good for newcomers and removed question Further information is requested labels Jun 15, 2022
@severo
Copy link
Collaborator Author

severo commented Sep 19, 2022

Moved to the internal tracker

@severo severo closed this as completed Sep 19, 2022
@severo severo mentioned this issue Sep 19, 2022
Closed
severo added a commit that referenced this issue Sep 21, 2022
@severo
feat: 🎸 change nginx logs to JSON
42c0550 
also:
- add the content of the request body (useful to get the content of the
  webhooks)
- automatically recreate the pod if the nginx configuration has changed.
  Closes #369,
  thanks @XciD
severo added a commit that referenced this issue Sep 21, 2022
@severo
Use json logs in nginx (#579)
eccfd0a 
* feat: 🎸 change nginx logs to JSON

also:
- add the content of the request body (useful to get the content of the
  webhooks)
- automatically recreate the pod if the nginx configuration has changed.
  Closes #369,
  thanks @XciD

* chore: 🤖 add an annotation to let elastic know logs are json
mattstern31 added a commit to mattstern31/datasets-server-storage-admin that referenced this issue Nov 11, 2023
@mattstern31
Use json logs in nginx (#579)
da54038 
* feat: 🎸 change nginx logs to JSON

also:
- add the content of the request body (useful to get the content of the
  webhooks)
- automatically recreate the pod if the nginx configuration has changed.
  Closes huggingface/dataset-viewer#369,
  thanks @XciD

* chore: 🤖 add an annotation to let elastic know logs are json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@severo @XciD