Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for futures v0.3.0-alpha.15 #193

Merged
merged 1 commit into from
May 3, 2019

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Apr 27, 2019

Remove FutureObj usage and futures_api feature

Blocked on an http-service release with http-rs/http-service#23

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Nemo157
Copy link
Contributor Author

Nemo157 commented Apr 29, 2019

@yoshuawuyts any chance of an http-service-mock v0.2.0 release? That's the only remaining blocker for this.

@yoshuawuyts
Copy link
Member

@Nemo157 published!

@Nemo157 Nemo157 marked this pull request as ready for review April 29, 2019 13:27
src/app.rs Outdated Show resolved Hide resolved
@Nemo157 Nemo157 force-pushed the futures-alpha.15 branch 2 times, most recently from c873f95 to 39dd6bb Compare April 30, 2019 14:01
@Nemo157
Copy link
Contributor Author

Nemo157 commented Apr 30, 2019

I've had to add a hack to the Cargo.toml to workaround a breaking change in ascii-canvas v1.0.1, there appears to already be an open issue about it so this can be removed once it gets yanked.

EDIT: Resolved and hack removed.

Remove FutureObj usage and futures_api feature
@Nemo157 Nemo157 force-pushed the futures-alpha.15 branch from b4b160a to a676391 Compare May 1, 2019 08:41
niklasf added a commit to lichess-org/lila-tablebase that referenced this pull request May 1, 2019
@tirr-c tirr-c merged commit 69b5762 into http-rs:master May 3, 2019
@Nemo157 Nemo157 deleted the futures-alpha.15 branch July 4, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants