Skip to content
This repository has been archived by the owner on Jun 21, 2020. It is now read-only.

Update for futures v0.3.0-alpha.15 #23

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Update for futures v0.3.0-alpha.15 #23

merged 1 commit into from
Apr 29, 2019

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Apr 27, 2019

Remove FutureObj/StreamObj usage and futures_api feature.

Description

Motivation and Context

Fixes #20

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Nemo157 Nemo157 mentioned this pull request Apr 27, 2019
Merged
8 tasks
@Nemo157
Update for futures v0.3.0-alpha.15
95d701d 
Remove FutureObj/StreamObj usage and futures_api feature.
yoshuawuyts
yoshuawuyts approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent, thanks so much!

@yoshuawuyts yoshuawuyts merged commit 3c69a10 into http-rs:master Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove StreamObj and use Pin<Box<dyn Stream>> instead
2 participants
@Nemo157 @yoshuawuyts