Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BellyAndWing foundation type and ManufacturedHomeSections #360

Merged
merged 41 commits into from
Aug 8, 2023
Merged

Add BellyAndWing foundation type and ManufacturedHomeSections #360

merged 41 commits into from
Aug 8, 2023

Conversation

nmerket
Copy link
Contributor

@nmerket nmerket commented Dec 6, 2022 •
edited
Loading

See #289

Adds BellyAndWing foundation type to support mobile homes.

image

HPXMLBaseElements_FoundationType

BellyAndWing

Documentation

The floor is supported on a pair of I-beams spanning across the length of the manufactured home. The floor wing is the part of the floor outside the supports, and the floor belly is the part between the supports. The floor wing and belly sections are protected from outside elements including water, wind, and rodents using a wrap attached to the underside of floor joists, and may contain insulation. Use separate Floor elements to describe the floor insulation above the belly and wing sections respsectively.

BellyWrapCondition

Enumerations

  • good
  • fair
  • poor
  • none

Documentation

Use the 'none' choice for cases where the belly wrap is functionally missing even if pieces of the wrap are still present.

@nmerket
Copy link
Contributor Author

nmerket commented Dec 6, 2022

Documentation on BellyAndWing (largely borrowed from the MHEA documentation):

The floor is supported on a pair of I-beams spanning across the length of the mobile home. The floor wing is the part of the floor outside the supports, and the floor belly is the part between the supports. The floor wing and belly sections are protected from outside elements including water, wind, and rodents using a wrap attached to the underside of floor joists, and may contain insulation. Use separate Floor elements to describe the floor insulation above the belly and wing sections respsectively.

nmerket
nmerket commented Dec 6, 2022
View reviewed changes
Copy link
Contributor Author

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Include the insulation on the belly wrap in the floor assembly insulation elements.
  • Make sure we can adequately describe the condition of the belly wrap and insulation (i.e. "catastrophic")

schemas/HPXMLDataTypes.xsd Outdated Show resolved Hide resolved
@nmerket
Copy link
Contributor Author

nmerket commented Dec 6, 2022

HUD Guide

@nmerket
Copy link
Contributor Author

nmerket commented Dec 14, 2022

🎥 Discussion in HPXML Working Group Meeting 2022-12-06

@shorowit shorowit marked this pull request as draft January 10, 2023 22:01
@nmerket
Copy link
Contributor Author

nmerket commented Jan 13, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-01-10

nmerket
nmerket commented Feb 14, 2023
View reviewed changes
schemas/HPXMLDataTypes.xsd Outdated
Comment on lines 3305 to 3310
<xs:restriction base="xs:string">
<xs:enumeration value="good"/>
<xs:enumeration value="fair"/>
<xs:enumeration value="poor"/>
<xs:enumeration value="catastrophic"/>
</xs:restriction>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend removing "catastrophic". Add a "none" enumeration instead.

nmerket
nmerket commented Feb 14, 2023
View reviewed changes
schemas/HPXMLBaseElements.xsd Outdated
@@ -1168,6 +1168,7 @@
</xs:element>
<xs:element minOccurs="0" name="InteriorFinish" type="InteriorFinishInfo"/>
<xs:element minOccurs="0" maxOccurs="1" name="Insulation" type="InsulationInfo"/>
<xs:element minOccurs="0" name="MobileHomeBellyOrWing" type="MobileHomeBellyOrWing"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some documentation to the FrameFloor to describe that the ExteriorAdjacentTo should be ambient for mobile home belly and wing.

@nmerket
Copy link
Contributor Author

nmerket commented Feb 15, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-02-14

nmerket
nmerket commented Apr 11, 2023
View reviewed changes
Copy link
Contributor Author

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes on what I've done and the reasoning. I removed the Floor/ManufacturedHomeBellyOrWing element because we can specify that with the ExteriorAdjacentTo and it was redundant.

merged_schema/HPXMLMerged.xsd Outdated
Comment on lines 5265 to 5266
<xs:documentation>The floor is supported on a pair of I-beams spanning across the length of the manufactured home. The floor wing is the part of the floor outside the supports, and the floor belly is the part between the supports. The floor wing and belly sections are protected from outside elements including water, wind, and rodents using a wrap attached to the underside of floor joists, and may contain insulation. Use separate Floor elements to describe the floor insulation above the belly and wing sections respsectively.
</xs:documentation>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the documentation for the BellyAndWing foundation type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some extra documentation about when to use a crawlspace.

merged_schema/HPXMLMerged.xsd
Comment on lines +6775 to +6782
<xs:simpleType name="ManufacturedHomeSections_simple">
<xs:restriction base="xs:string">
<xs:enumeration value="single-wide"/>
<xs:enumeration value="double-wide"/>
<xs:enumeration value="triple-wide"/>
<xs:enumeration value="CrossMod"/>
</xs:restriction>
</xs:simpleType>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to <BuildingSummary> to capture the high level configuration of the maufactured home. This seemed to be the options that were out there. CrossMod is an industry term that is being built by a couple different manufacturers. It seems functionally more like a single family detached home, but it would be good to denote.

merged_schema/HPXMLMerged.xsd
@@ -7174,6 +7208,7 @@
<xs:enumeration value="garage - unconditioned"/>
<xs:enumeration value="ground"/>
<xs:enumeration value="living space"/>
<xs:enumeration value="manufactured home underbelly"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enumeration goes on the <ExteriorAdjacentTo> element, mostly so floors can specify the underbelly area is below them.

merged_schema/HPXMLMerged.xsd
@@ -7996,6 +8031,7 @@
<xs:enumeration value="crawlspace - unconditioned"/>
<xs:enumeration value="crawlspace - unvented"/>
<xs:enumeration value="crawlspace - vented"/>
<xs:enumeration value="manufactured home belly"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enumeration goes with ducts so that a duct can be inside the belly. Hence the naming difference.

@nmerket nmerket changed the title Add BellyAndWing foundation type Add BellyAndWing foundation type and ManufacturedHomeSections Apr 11, 2023
@nmerket
Copy link
Contributor Author

nmerket commented Apr 11, 2023

Come up with some guidance on the area of the floor and insulation level and materials.

@nmerket
Copy link
Contributor Author

nmerket commented Apr 13, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-04-11

@nmerket nmerket mentioned this pull request Apr 26, 2023
Merged
4 tasks
@shorowit shorowit mentioned this pull request Apr 28, 2023
Merged
7 tasks
@nmerket
Copy link
Contributor Author

nmerket commented Jun 13, 2023

We should have good documentation of CrossMod homes and how they're different from single family detached homes.

@nmerket
Copy link
Contributor Author

nmerket commented Jun 21, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-06-13

@nmerket nmerket added the merge label Jul 11, 2023
@nmerket
Copy link
Contributor Author

nmerket commented Jul 12, 2023

🎥 Discussion in HPXML Working Group Meeting 2023-07-11

@nmerket nmerket merged commit e682819 into master Aug 8, 2023
@nmerket nmerket deleted the belly_and_wing branch August 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

Assignees

@nmerket nmerket

Labels
discussion needed merge schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerket @shorowit