Geometry Envelope Additions #221

nmerket · 2023-03-29T16:37:53Z

Replacement PR for #216

Pull Request Description

Goes with https://github.com/NREL/OpenStudio-HEScore/pull/367

Checklist

PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply.

PR Reviewer: Verify each has been completed.

Code changes (must work)
Test exercising your feature or bug fix. Check the coverage report in the build artifacts.
All other unit tests passing
Update translation docs

…ixes

…only allow adjacent to "outside"; Fix get_wall_assembly_code_and_rvalue;

…-hpxml into geometry_envelope_additions

…Change enclosure_adjacent_to_map to wall_adjacent_to_map

bpark1327 · 2023-03-29T16:41:26Z

Noel's review comments:
#216 (review)

Scott's review comment:
#216 (comment)

github-actions · 2023-03-29T21:12:10Z

File	Coverage
All files	`93%`	✅
__init__.py	`83%`	✅
base.py	`94%`	✅
exceptions.py	`96%`	✅
hpxml2.py	`88%`	✅
hpxml3.py	`86%`	✅

Minimum allowed coverage is 83%

Generated by 🐒 cobertura-action against df300c9

nmerket · 2023-04-04T15:26:32Z

@bpark1327 I changed the base branch for this PR to match what we have in the other repo. Let me know if you have any questions on my comments.

Co-authored-by: Noel Merket <noel.merket@nrel.gov>

…deprecated

…e Width to about.rst

…idationError message

docs/source/translation/about.rst

…schema

nmerket

Still to do:

Add translation for HPXML v3 with extension elements that are named the same as the proposed manufactured home things in Add BellyAndWing foundation type and ManufacturedHomeSections hpxmlwg/hpxml#360
Update docs for those changes

bpark1327 · 2023-04-27T22:13:07Z

Added Building/BuildingDetails/BuildingSummary/BuildingConstruction/extension/ManufacturedHomeSections and docs are updated accordingly.
When we merge https://github.com/hpxmlwg/hpxml/pull/360/files, this should be changed to Building/BuildingDetails/BuildingSummary/BuildingConstruction/ManufacturedHomeSections

@nmerket Do you think this is what you expected? In this PR, should I add other manufactured home elements (e.g., ManufacturedHomeBellyWrapCondition)?

bpark1327 · 2023-05-02T18:02:48Z

Added Building/BuildingDetails/BuildingSummary/BuildingConstruction/extension/ManufacturedHomeSections and docs are updated accordingly. When we merge https://github.com/hpxmlwg/hpxml/pull/360/files, this should be changed to Building/BuildingDetails/BuildingSummary/BuildingConstruction/ManufacturedHomeSections

@nmerket Do you think this is what you expected? In this PR, should I add other manufactured home elements (e.g., ManufacturedHomeBellyWrapCondition)?

@nmerket I think this is ready for your review unless we want to add other manufactured home elements besides ManufacturedHomeSections.

nmerket

Looks pretty good. A few minor recommendations below.

docs/source/translation/about.rst

hescorehpxml/schemas/hescore_json.schema.json

…ached; Update docs

bpark1327 · 2023-05-04T18:30:31Z

@nmerket I've addressed your latest comments. Please let me know what you think.

nmerket · 2023-05-04T19:18:44Z

It looks good to me. Github won't let me officially approve because I opened the PR, but I approve.

bpark1327 and others added 26 commits February 22, 2023 09:34

First pass

e80fe92

Upload the latest json schema

5f1efdd

update JSON schema and tests

7374f37

Run flake8

0b43554

add lu_int_wall_eff_rvalue.csv

8bdbb3b

Update the Python version list

30d64aa

Fix python-version

2c8eefc

Require walls facing each direction with the AdjacentTo element; Bugf…

832d867

…ixes

Update docs

4d9086a

Correct a comment

87f39e0

Remove _v3.json and -v2.json files; Cleanup base.py

8d1db2c

Update test_translation.py

bccad82

Merge branch 'master' into geometry_envelope_additions

c8b2809

Pull interior wall assembly codes from the json schema

daedf95

Raise TranslationError when get_enclosure_adjacent_to returns None

99e7434

Omit the zone_window if there are no windows on the side of the house

ed4b36e

Add schema validation for single family detached and mobile homes to …

77d129e

…only allow adjacent to "outside"; Fix get_wall_assembly_code_and_rvalue;

Merge branch 'geometry_envelope_additions' of github.com:NREL/hescore…

4b674a3

…-hpxml into geometry_envelope_additions

Schema bugfix; update zone_wall doc

cbc5975

Avoid line too long error

737c617

Add a test for invalid wall adjacent_to

3a954a0

Remove 'building' property from the top level

b97529d

Remove other housing unit above/below from wall adjacent_to mapping; …

4650084

…Change enclosure_adjacent_to_map to wall_adjacent_to_map

Remove windows with 0 area from example files

3a10813

Update JSON schema and tests

ba932a7

Remove Surroundings element from examples

29df543

bpark1327 self-assigned this Mar 29, 2023

Update the message in assert_required_error

4a72767

nmerket changed the base branch from master to os350 April 4, 2023 15:19

bpark1327 and others added 9 commits April 4, 2023 14:50

Update hescorehpxml/base.py

43c5bed

Co-authored-by: Noel Merket <noel.merket@nrel.gov>

Update hescorehpxml/base.py

c5bcaa8

Co-authored-by: Noel Merket <noel.merket@nrel.gov>

Remove try except statement around heswall['adjacent_to']

32e5b32

Add a warning that Building/BuildingSummary/Site/Surroundings is …

ae601a6

…deprecated

Added description of Building Dwelling Unit Type and Manufactured Hom…

b72349f

…e Width to about.rst

Bugfix in base.py

20fc2c0

Change test_invalid_number_of_walls to search for a key string in Val…

26fb4f6

…idationError message

Allows for flat roof translation

872d76a

Allow for AboveApartment translation

72bc6ae

shorowit reviewed Apr 5, 2023

View reviewed changes

docs/source/translation/about.rst Outdated Show resolved Hide resolved

docs/source/translation/about.rst Outdated Show resolved Hide resolved

bpark1327 added 3 commits April 5, 2023 10:49

Revise about.rst

7e1b8a8

Change manufactured_home_width to manufactured_home_sections

fd64956

Change manufactured_home_width to manufactured_home_sections in JSON …

01d16d8

…schema

nmerket commented Apr 26, 2023

View reviewed changes

bpark1327 added 4 commits April 27, 2023 12:38

Update Manufactured Home Sections in about.rst

19fca9c

Add CrossMod to manufactured_home_sections enum

193f971

Add a test for ManufacturedHomeSections

813e40c

Add ManufacturedHomeSections translation

9b0b7c4

nmerket commented May 2, 2023

View reviewed changes

docs/source/translation/about.rst Outdated Show resolved Hide resolved

hescorehpxml/schemas/hescore_json.schema.json Outdated Show resolved Hide resolved

hescorehpxml/schemas/hescore_json.schema.json Show resolved Hide resolved

Require there not to be a zone_window property for walls that are att…

1a89cf0

…ached; Update docs

shorowit mentioned this pull request May 4, 2023

Better error message for impossible townhouse walls #211

Closed

Remove CrossMod from ManufacturedHomeSections enums

df300c9

nmerket merged commit 8e905a9 into os350 May 4, 2023

nmerket deleted the geometry_envelope_additions branch May 4, 2023 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geometry Envelope Additions #221

Geometry Envelope Additions #221

nmerket commented Mar 29, 2023 •

edited by bpark1327

Loading

bpark1327 commented Mar 29, 2023

github-actions bot commented Mar 29, 2023 •

edited

Loading

nmerket commented Apr 4, 2023

nmerket left a comment •

edited by bpark1327

Loading

bpark1327 commented Apr 27, 2023 •

edited

Loading

bpark1327 commented May 2, 2023

nmerket left a comment

bpark1327 commented May 4, 2023

nmerket commented May 4, 2023

Geometry Envelope Additions #221

Geometry Envelope Additions #221

Conversation

nmerket commented Mar 29, 2023 • edited by bpark1327 Loading

Pull Request Description

Checklist

bpark1327 commented Mar 29, 2023

github-actions bot commented Mar 29, 2023 • edited Loading

nmerket commented Apr 4, 2023

nmerket left a comment • edited by bpark1327 Loading

Choose a reason for hiding this comment

bpark1327 commented Apr 27, 2023 • edited Loading

bpark1327 commented May 2, 2023

nmerket left a comment

Choose a reason for hiding this comment

bpark1327 commented May 4, 2023

nmerket commented May 4, 2023

nmerket commented Mar 29, 2023 •

edited by bpark1327

Loading

github-actions bot commented Mar 29, 2023 •

edited

Loading

nmerket left a comment •

edited by bpark1327

Loading

bpark1327 commented Apr 27, 2023 •

edited

Loading