Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding heat pump backup reference #136

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Adding heat pump backup reference #136

merged 1 commit into from
Aug 3, 2018

Conversation

nmerket
Copy link
Contributor

@nmerket nmerket commented Jul 30, 2018

Adds two elements:

baseelements_heatpumpinfotype

BackupType

Documentation:

Whether the heat pump backup is integrated into the unit (describe in BackupSystemFuel, BackupAFUE, BackupHeatingCapacity), or a separate heating system (add reference in BackupSystem).

Enumerations

  • integrated
  • separated

BackupSystem

Including an idref to point to a HeatingSystem.

Documentation:

References the HeatingSystem that provides the backup for a separate backup.

Fixes #110

@nmerket nmerket requested a review from GamalielL July 30, 2018 21:49
@nmerket nmerket added this to the v2.3 milestone Jul 30, 2018
@nmerket nmerket changed the title adding heat pump backup reference Adding heat pump backup reference Jul 30, 2018
@nmerket nmerket merged commit 965964b into master Aug 3, 2018
@nmerket nmerket deleted the 110_heat_pump_backup branch August 3, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GamalielL GamalielL GamalielL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerket @GamalielL