Fix compile warnings #605
Merged
Fix compile warnings #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of setgroups() requires including <grp.h>.
Fixes warning:
src/dcp/dcp.c:416:13: warning: implicit declaration of function ‘setgroups’; did you mean ‘getgroups’? [-Wimplicit-function-declaration]
416 | if (setgroups(0, NULL) < 0) {
| ^~~~~~~~~
| getgroups
[ 50%] Linking C executable dcp
gids[MAX_GIDS] is used by getgroups(). The second argument should be of type gid_t *.
Fixes warning:
src/dcp/dcp.c:407:42: warning: passing argument 2 of ‘getgroups’ from incompatible pointer type [-Wincompatible-pointer-types]
407 | gids_count = getgroups(MAX_GIDS, &gids);
| ^~~~~
| |
| uid_t (*)[100] {aka unsigned int (*)[100]}
In file included from src/dcp/dcp.c:7:
/usr/include/unistd.h:689:43: note: expected ‘__gid_t *’ {aka ‘unsigned int *’} but argument is of type ‘uid_t (*)[100]’ {aka ‘unsigned int (*)[100]’}
689 | extern int getgroups (int __size, __gid_t __list[]) __THROW __wur;
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Fix this warning: [ 21%] Building C object src/common/CMakeFiles/mfu_o.dir/mfu_io.c.o src/common/mfu_io.c:1673:8: warning: extra tokens at end of #endif directive [-Wendif-labels] 1673 | #endif DCOPY_USE_XATTRS | ^~~~~~~~~~~~~~~~ The DCOPY_USE_XATTRS is a helpful clue to which #if corresponds to the endif, but the endif pragma does not take an argument. Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
|
@bdevcich see above minor fixes to gid-related code. |
|
Thanks @ofaaland. Not sure how I missed this. |
bdevcich
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix three compile warnings observed when building with gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-7)
#endifsetgroups()getgroups()