-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dfilemaker: Specify desired tree with options -d, -n, -s, -f #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8df7801
to
51376e1
Compare
Rebased on main, which advanced when I merged #605 unrelated to dfilemaker |
carbonneau1
reviewed
Nov 21, 2024
carbonneau1
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I came too late.
Support complex tree with control over data, depth of tree, number of files, and more. * Use getopt_long to support both short and long options * Added option "-d" for directory tree depth * Added option "-f" for fill type, specifying data for files should contain all random values, all 0's, all 0xAAAAAAAA, or 0xFFFFFFFF. * Added option "-n" for number of files. * Added option "-r" for ratio of files to directories (not implemented) * Added option "-s" for file size * Added option "-w" for directory tree width (not implemented) * Modified "-s" option to use mfu abtoull to parse terms with KB, MB, GB. * specify ranges for "-d", "-n", "-s", and "-w" (ie create files 1K-1M in size) Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
* Remove whitespace at end of line * Replace printf/fflush with MFU_LOG for consistency with other tools * Switch file sizes ot uint64_t per Adam Moody this is what other tools use for file size * brace style change change braces and indenting for if/while/for blocks to match rest of code * remove JoAnne dfilemaker makefile JoAnne added a makefile for testing, but CMake will generate one for us Also, address minor issues noted * remove unused variable ifac * clarify filltype in code, using an enum for the types supported * respect --help argument and exit * clarify usage of buf Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
51376e1
to
7d9049e
Compare
carbonneau1
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: JoAnne Levatin levatin1@llnl.gov
Author: Olaf Faaland faaland1@llnl.gov
Replaces PR #269