Revert "allow customizing the element that Drive replaces (#627)" #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 37ed6bc.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 14, 2022
The changes originally introduced in [hotwired#627][] had some negative side effects, including a batch of the [current Chrome failures][ci]. To resolve the issues, the diff was reverted by [hotwired#715][]. This commit re-introduces the changes proposed in [hotwired#627][] with additional test coverage to ensure that the rendering timing plays nice with Snapshot caching and other existing rendering behavior. [hotwired#627]: hotwired#627 [ci]: https://github.com/hotwired/turbo/actions/runs/3045476866/jobs/4907085095 [hotwired#715]: hotwired#715 Co-authored-by: Alex Robbin <agrobbin@gmail.com>
This was referenced Sep 14, 2022
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 37ed6bc.
Unfortunately, the issues with #627 outlined in #711 are more nuanced than originally anticipated, and might be at the root of 7.2.0.rc-1 issues like #713.
This commit reverts that changeset. Once this merges, #711 can be repurposed to re-introduce that feature in a way that works with
PageViewrendering andSnapshotCache-timing.