Re-introduce #627 #711
Re-introduce #627 #711
Conversation
seanpdoyle
force-pushed
the
fix-ci
branch
5 times, most recently
from
967c9fc to
98cde44
Compare
The changes originally introduced in [hotwired#627][] had some negative side effects, including a batch of the [current Chrome failures][ci]. To resolve the issues, the diff was reverted by [hotwired#715][]. This commit re-introduces the changes proposed in [hotwired#627][] with additional test coverage to ensure that the rendering timing plays nice with Snapshot caching and other existing rendering behavior. [hotwired#627]: hotwired#627 [ci]: https://github.com/hotwired/turbo/actions/runs/3045476866/jobs/4907085095 [hotwired#715]: hotwired#715 Co-authored-by: Alex Robbin <agrobbin@gmail.com>
|
@seanpdoyle what are we missing to reintroduce this change? |
The implementation needs to be changed so that the test suite passes. The failures in CI are genuine. |
|
The only test I see consistently fail locally is
looking at the test, it checks if the cache is updated if the body is mutated after it gets removed, but before the cache happens. Is that something Turbo has to support? what's the use case there? |
|
Is this still possible to include this feature? My application uses a Spotify audio player iframe, meaning that even with the |
Restore #627
The changes originally introduced in hotwired/turbo#627 had some
negative side effects, including a batch of the current Chrome
failures.
To resolve the issues, the diff was reverted by hotwired/turbo#715.
This commit re-introduces the changes proposed in hotwired/turbo#627
with additional test coverage to ensure that the rendering timing plays
nice with Snapshot caching and other existing rendering behavior.
Co-authored-by: Alex Robbin agrobbin@gmail.com