-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: details page for pre-order catalog (#85zt0m4qc) #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs section and improved code to show skeleton text (#85zt0m4qc)
…ed naming (#85zt0m4qc)
… accordingly (#85zt0m4qc)
…pty values and no responses in the UI (#85zt0m4qc)
…ing configs and logic for fetching jobs (#85zt0m4qc)
1. Improved action to handle cached data and forced update. Added try catch to handle errors 2. Improved getter, productStoreId should be passed instead of used from rootState. It would easier to reuse getter. 3. Fixed issue with update not working from second time, getters were used when passing the value and actions do not foce update
…ge (#85zt0m4qc) Additionally removed logic to get fromDate using PreOrderCategoryProducts entity and used exisiting data from ProductDcsnReason
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #128
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and Currently Important Rules Acceptance