Implemented: details page for pre-order catalog (#85zt0m4qc) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs section and improved code to show skeleton text (#85zt0m4qc)
adityasharma7
suggested changes
May 25, 2023
src/store/modules/job/actions.ts
Outdated
|
|
||
| requests.push(JobService.fetchJobInformation(params).catch((error: any) => error)) | ||
|
|
||
| resp = await Promise.all(requests) |
There was a problem hiding this comment.
We should use allSettled()
src/store/modules/job/actions.ts
Outdated
| if (!hasError(resp[1])) { | ||
| const pendingJobs = Object.values(resp[1].data.docs.reduce((jobs: [any], job: any) => { | ||
| // keeping the job with the highest runTime | ||
| if (!jobs[job.systemJobEnumId] || job.runTime > jobs[job.systemJobEnumId].runTime) { |
There was a problem hiding this comment.
We should sort by runtime and then || job.runTime > jobs[job.systemJobEnumId].runTime will not be required
src/store/modules/user/actions.ts
Outdated
| @@ -124,6 +125,9 @@ const actions: ActionTree<UserState, RootState> = { | |||
| } | |||
| commit(types.USER_CURRENT_ECOM_STORE_UPDATED, userPrefStore); | |||
| commit(types.USER_INFO_UPDATED, userProfile); | |||
| this.dispatch('util/getServiceStatusDesc') | |||
| await dispatch('getReserveInvConfig', userPrefStore.productStoreId) | |||
There was a problem hiding this comment.
Get this config on page load
src/store/modules/user/actions.ts
Outdated
| */ | ||
| async updatePreOrdPhyInvHoldStatus({ dispatch, state }, payload) { | ||
| // Handled initial programmatical update | ||
| // When storing boolean values, it is stored as string. Further comparison needs conversion |
There was a problem hiding this comment.
This should handled from UI
src/store/modules/user/actions.ts
Outdated
| /** | ||
| Update preorder physical inventory hold config | ||
| */ | ||
| async updatePreOrdPhyInvHoldStatus({ dispatch, state }, payload) { |
There was a problem hiding this comment.
Suggested change
| async updatePreOrdPhyInvHoldStatus({ dispatch, state }, payload) { | |
| async updatePreOrdPhyInvHoldConfig({ dispatch, state }, payload) { |
src/store/modules/user/actions.ts
Outdated
| @@ -153,6 +157,8 @@ const actions: ActionTree<UserState, RootState> = { | |||
| 'userPrefTypeId': 'SELECTED_BRAND', | |||
| 'userPrefValue': payload.eComStore.productStoreId | |||
| }); | |||
| await dispatch('getReserveInvConfig', payload.eComStore.productStoreId) | |||
| await dispatch('getPreOrdPhyInvHoldConfig', payload.eComStore.productStoreId) | |||
There was a problem hiding this comment.
I think we should clear here
| </div> | ||
|
|
||
| <div> | ||
| <ion-card v-if="pOAndATPDetails.isLoaded && pOSummary.isLoaded"> |
There was a problem hiding this comment.
isLoaded use purpose specific properties to handle it
alsoK2maan
changed the title
…ed naming (#85zt0m4qc)
… accordingly (#85zt0m4qc)
…pty values and no responses in the UI (#85zt0m4qc)
adityasharma7
suggested changes
Jun 14, 2023
| // get last active PO ID if active PO ID is not found | ||
| payload = { | ||
| "inputFields": { | ||
| "productId": this.$route.params.variantId, |
There was a problem hiding this comment.
Ensure that if user hits the URL without variantId, there are no API calls
…ing configs and logic for fetching jobs (#85zt0m4qc)
adityasharma7
suggested changes
Jun 19, 2023
| // fetch fromDate only for active POs in pre-order/back-order category | ||
| if (this.poSummary.isActivePo) { | ||
| if (this.poSummary.categoryId) { | ||
| let resp: any = await OrderService.getPoFromDate({ |
There was a problem hiding this comment.
Need to check if we could use fromDate field from ProductCategoryDcsnRsn
adityasharma7
suggested changes
Jun 19, 2023
| // TODO - internationalize header after getting generic strings | ||
| if (!hasError(resp)) { | ||
| const fromDate = resp.data.docs[0].fromDate | ||
| if (this.configsByStores.length > this.poSummary.listedCount) { |
There was a problem hiding this comment.
Need to simplify this logic, use flags to determine decision variable and then prepare messages
adityasharma7
suggested changes
Jun 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #125
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance