Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute path for BUILDEVENTS_FILE #39

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Use absolute path for BUILDEVENTS_FILE #39

merged 1 commit into from
Feb 27, 2021

Conversation

sargunv
Copy link
Contributor

@sargunv sargunv commented Feb 26, 2021 •
edited
Loading

Fixes #38

Tested locally like this:

image

@sargunv sargunv marked this pull request as ready for review February 26, 2021 23:34
@yvrhdn
Copy link

yvrhdn commented Feb 27, 2021

Thanks! I also pushed the commit to a local branch (GitHub Actions doesn't work on forks) and CI works as expected 👍

Screenshot 2021-02-27 at 13 12 47

@yvrhdn yvrhdn merged commit 893b7ec into honeycombio:main Feb 27, 2021
@yvrhdn
Copy link

yvrhdn commented Feb 27, 2021

Hi @sargunv, thank you for contributing the PR. This has been released with v1.0.5, but if you use gha-buildevents@v1 it should use the newest version automatically 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make BUILDEVENTS_FILE an absolute path
2 participants
@sargunv @yvrhdn