Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BUILDEVENTS_FILE an absolute path #38

Closed
sargunv opened this issue Feb 26, 2021 · 2 comments · Fixed by #39
Closed

Make BUILDEVENTS_FILE an absolute path #38

sargunv opened this issue Feb 26, 2021 · 2 comments · Fixed by #39

Comments

@sargunv
Copy link
Contributor

sargunv commented Feb 26, 2021

Often times I run a script via buildevents cmd in a directory other than my workspace root, but the command doesn't find the buildevents.txt file because the value of $BUILDEVENTS_FILE is ../buildevents.txt. It should be an absolute path instead by default to allow easily using this from any working directory.

@yvrhdn
Copy link

yvrhdn commented Feb 26, 2021

Thanks for the report! We should be able to set this to an absolute path without much issue. We'll just have to figure out a good path.
The default value is set here: https://github.com/kvrhdn/gha-buildevents/blob/70cba094455143d466a64779533131eb1b28e105/src/buildevents.ts#L36-L37

@sargunv
Copy link
Contributor Author

sargunv commented Feb 26, 2021

Could just replace it with envPath = path.resolve('../buildevents.txt'). That way we'll use the exact same path we're using now, and work just fine with custom runners with their own file structure.

I'd be happy to PR this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants