Update password comparison to timing safe #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BlenderDude Can you explain the changes in laymans terms? I guess this would not result in any difference in behaviour for a standard user logging in? |
Pull Request Test Coverage Report for Build 6226959456
💛 - Coveralls |
donavanbecker
approved these changes
Sep 24, 2023
Merged
donavanbecker
added a commit
that referenced
this pull request
Sep 28, 2023
## 4.50.6 (2023-09-27) ### Bug Fixes - **System:** Update comparison to timing safe ([1535](#1535)) ### Other Changes - **i18n:** Update pt.json ([1503](#1520)) - **i18n:** Use verb form for buttons and menu items ([1533](#1533)) - **i18n:** Wait for custom UI ([1526](#1526)) - Updated npm dependencies --------- Co-authored-by: Dave Nicolson <david.nicolson@gmail.com> Co-authored-by: Donavan Becker <beckersmarthome@icloud.com> Co-authored-by: SamuelMagano <samuelmagano_16@hotmail.com> Co-authored-by: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Co-authored-by: Daniel Abdelsamed <daniel@abdelsamed.com> Co-authored-by: Donavan Becker <donavan.becker@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Current password check code allows for the hash to be guessed utilizing a timing attack.
💡 Proposed solution
Simple update to the password check function that utilizes
crypto.timingSafeEqualsuch that comparisons are always the same time.⚙️ Release Notes
Increased password security with timing safe comparison
Testing
Testing should be covered by existing cases in
auth.e2e-spec.ts