Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for custom UI #1526

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Wait for custom UI #1526

merged 1 commit into from
Aug 21, 2023

Conversation

dnicolson
Copy link
Contributor

♻️ Current situation

The #1522 fix can still sometimes be called too early.

💡 Proposed solution

Set uiLoaded after the scrollHeight message event.

@donavanbecker
Copy link
Contributor

I will get a new beta branch going.

@dnicolson
Copy link
Contributor Author

I will get a new beta branch going.

Five pull requests were closed when the beta-4.50.5 was deleted, GitHub now deletes pull requests on branch deletion. Is it possible to reopen them from your end?

@donavanbecker
Copy link
Contributor

I definitely could but we will want all the other changes we have from master.

@donavanbecker donavanbecker changed the base branch from master to beta-4.50.6 August 21, 2023 22:29
@donavanbecker
Copy link
Contributor

I have rebased to branch beta-4.50.6

@donavanbecker donavanbecker enabled auto-merge (squash) August 21, 2023 22:30
@donavanbecker donavanbecker merged commit e5fc138 into homebridge:beta-4.50.6 Aug 21, 2023
15 of 23 checks passed
@donavanbecker donavanbecker mentioned this pull request Sep 27, 2023
Merged
donavanbecker added a commit that referenced this pull request Sep 28, 2023
@bwp91 @dnicolson
@donavanbecker @SamuelMagano @NorthernMan54 @BlenderDude
beta -> main (#1546)
5cc7065 
## 4.50.6 (2023-09-27)

### Bug Fixes

- **System:** Update comparison to timing safe ([1535](#1535))

### Other Changes

- **i18n:** Update pt.json ([1503](#1520))
- **i18n:** Use verb form for buttons and menu items ([1533](#1533))
- **i18n:** Wait for custom UI ([1526](#1526))
- Updated npm dependencies

---------

Co-authored-by: Dave Nicolson <david.nicolson@gmail.com>
Co-authored-by: Donavan Becker <beckersmarthome@icloud.com>
Co-authored-by: SamuelMagano <samuelmagano_16@hotmail.com>
Co-authored-by: Northern Man <19808920+NorthernMan54@users.noreply.github.com>
Co-authored-by: Daniel Abdelsamed <daniel@abdelsamed.com>
Co-authored-by: Donavan Becker <donavan.becker@icloud.com>
@donavanbecker donavanbecker mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnicolson @donavanbecker