Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation alert for notification categories #1976

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

zacwest
Copy link
Member

@zacwest zacwest commented Dec 6, 2021

Summary

Alerts if there are any notification categories (local or synced) if the user is an admin on any of their servers.

The configuration is marked as deprecated in home-assistant/core#61078 and will produce warnings until it's removed from there as well.

Screenshots

Light Dark
Simulator Screen Shot - iPhone 13 Pro - 2021-12-05 at 22 32 20 Simulator Screen Shot - iPhone 13 Pro - 2021-12-05 at 22 32 21

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1976 (112084f) into master (06f65be) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
- Coverage   29.05%   29.01%   -0.05%     
==========================================
  Files         268      268              
  Lines       20923    20954      +31     
==========================================
- Hits         6080     6079       -1     
- Misses      14843    14875      +32     
Impacted Files Coverage Δ
Sources/App/AppDelegate.swift 8.49% <0.00%> (-0.79%) ⬇️
...rces/Shared/Common/Extensions/URL+Extensions.swift 38.70% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f65be...112084f. Read the comment docs.

@zacwest zacwest merged commit e788cfe into master Dec 7, 2021
@zacwest zacwest deleted the notif-categories-warning branch December 7, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants