Deprecate ios push config (in favor of inline actions) #61078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
integration: ios
new-feature
small-pr
|
Hey there @robbiet480, mind taking a look at this pull request as it has been labeled with an integration ( |
|
This PR needs to be marked as a breaking change and needs a breaking change section in the PR description. |
|
Oh, deprecations are breaking changes? Gotcha. Will update. |
Well, yes/no. Deprecated will be logged, but the reason why is not clear from just this. The "breaking changes" marker adds this PR to the breaking changes section of the release notes, so we can explain "why" this is deprecated now. |
|
Added the section. I don't think I have the relevant permission to change the labels. |
zacwest
added a commit
to home-assistant/iOS
that referenced
this pull request
Dec 7, 2021
## Summary Alerts if there are any notification categories (local or synced) if the user is an admin on any of their servers. The configuration is marked as deprecated in home-assistant/core#61078 and will produce warnings until it's removed from there as well.
frenck
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The Home Assistant iOS/macOS app supports notification actions defined in the notification itself; the old method of defining categories with actions will be removed in the future.
Proposed change
Marks the
pushconfig as deprecated. Since iOS-2021.5 and macOS-2021.10, notification actions do not require setting up push configs in advance.Support for push configs will be removed from iOS in the near future (I'll ref this PR for the warning start iOS-side, too), so it is time to start warning about it when configured in configuration.yaml.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: