-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Automation/Script editor border-radius fix (#23267)" #23475
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have the squash available. I'll leave this one unmerged.
@MindFreeze can you provide clarifications for this? Update: I see your point, but cannot reproduce it - see no clipping here: |
@ildar170975 Try the second select in a device trigger Hmm, actually now it looks like the options are still accessible because the list is scrollable. It's just not obvious because there is no scrollbar and it looks cut off at the top and bottom. This can be considered an issue with the select I guess, but it is still not great that the list area is limited to the height of the trigger card. Another solution is to add |
Yes, see it now. Strange it is not observed with a "state trigger". |
Not cool. I will try to find a way. |
Proposed change
The
overflow: hidden
part hides some options when there is a select in the trigger/action so I reverted the PR and added default values for the border radius instead.Don't squash this PR, pls
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: