Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Automation/Script editor border-radius fix (#23267)" #23475

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

MindFreeze
Copy link
Contributor

Proposed change

The overflow: hidden part hides some options when there is a select in the trigger/action so I reverted the PR and added default values for the border radius instead.
Don't squash this PR, pls

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze added this to the 2025.1 milestone Dec 27, 2024
@ildar170975
Copy link
Contributor

ildar170975 commented Dec 27, 2024

added default values for the border radius instead.

I considered this option in my PR - but it caused this imperfection:
image

Although it is better than clipped options in "select".

From what I know you cannot expand a "select" field on a disabled trigger?
So when you will see these options then?

Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have the squash available. I'll leave this one unmerged.

@ildar170975
Copy link
Contributor

ildar170975 commented Dec 27, 2024

@MindFreeze can you provide clarifications for this?
I honestly cannot see how it is possible to use a "select" for a disabled element.

Update: I see your point, but cannot reproduce it - see no clipping here:
image
Will check it more.

@MindFreeze
Copy link
Contributor Author

MindFreeze commented Dec 27, 2024

@ildar170975 Try the second select in a device trigger

Hmm, actually now it looks like the options are still accessible because the list is scrollable. It's just not obvious because there is no scrollbar and it looks cut off at the top and bottom. This can be considered an issue with the select I guess, but it is still not great that the list area is limited to the height of the trigger card.

Another solution is to add overflow: hidden only when it is disabled but this wouldn't cover the triggered/testing cases

@ildar170975
Copy link
Contributor

Try the second select in a device trigger

Yes, see it now. Strange it is not observed with a "state trigger".
OK, will think how to fix that graphical imperfection then.

@MindFreeze
Copy link
Contributor Author

margin: -1px -1px 0 kind of fixes it but it overlaps the disabled background and the border
image

@ildar170975
Copy link
Contributor

margin: -1px -1px 0

Not cool. I will try to find a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants