Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation/Script editor border-radius fix #23267

Merged

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Dec 12, 2024

Breaking change

Proposed change

"Disabled bar" was overflowing.
Related to: ha-automation-condition-row, ha-automation-action-row, ha-automation-trigger-row, ha-script-field-row.
Old code was like

        .disabled-bar {
          ...
          border-top-right-radius: var(--ha-card-border-radius);
          border-top-left-radius: var(--ha-card-border-radius);
        }

w/o default values.
But even with default values it would cause artefacts.
So I removed these radiuses for .disabled-bar, .triggered, .testing and set overflow: hidden for ha-card.

before:
image

image

after:
image

image

Another issue is with undesired radius for selected ha-expansion-panel under .disabled-bar:
image
but have not found a good solution yet.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze merged commit e9b2a83 into home-assistant:dev Dec 12, 2024
16 checks passed
@ildar170975 ildar170975 deleted the automation_editor_disabled_radius branch December 12, 2024 13:49
MindFreeze added a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants