-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCKROBO_S4 to xiaomi_miio vaccum models #58682
Add ROCKROBO_S4 to xiaomi_miio vaccum models #58682
Conversation
#58550 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -197,9 +197,11 @@ class SetupException(Exception): | |||
) | |||
|
|||
# TODO: use const from pythonmiio once new release with the constant has been published. # pylint: disable=fixme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something holding up the pythonmiio release with these constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- its not merged yet: Add S4 to the list of supported models. rytilahti/python-miio#1169
- There will be no release soon: Xiaomi Miio Vacuum: Could not determine how to parse state value of type <class 'NoneType'> #57474 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the backstory
We agree on merging the S5Max too in this way. I think we should prevent end-user issues/reports and merge this one in now (and get it into beta). The upstream change is pending, so that is good 👍 |
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: