Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROCKROBO_S4 to xiaomi_miio vaccum models #58682

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Add ROCKROBO_S4 to xiaomi_miio vaccum models #58682

merged 1 commit into from
Oct 31, 2021

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Oct 29, 2021

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

#58550

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@OGKevin OGKevin marked this pull request as ready for review October 29, 2021 22:10
@@ -197,9 +197,11 @@ class SetupException(Exception):
)

# TODO: use const from pythonmiio once new release with the constant has been published. # pylint: disable=fixme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something holding up the pythonmiio release with these constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backstory

@frenck frenck added this to the 2021.11.0 milestone Oct 31, 2021
@frenck
Copy link
Member

frenck commented Oct 31, 2021

We agree on merging the S5Max too in this way. I think we should prevent end-user issues/reports and merge this one in now (and get it into beta).

The upstream change is pending, so that is good 👍

@bdraco bdraco merged commit e38f3e4 into home-assistant:dev Oct 31, 2021
@OGKevin OGKevin deleted the 58550-add-s4-to-vacuum-models branch October 31, 2021 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while setting up xiaomi_miio platform for vacuum
8 participants