Error while setting up xiaomi_miio platform for vacuum

[enkama]

The problem

So after updating to the latest beta 2021.11.0b0 my s5 max isnt getting setup anymore.

What version of Home Assistant Core has the issue?

2021.11.0b0

What was the last working version of Home Assistant Core?

2021.10.6

What type of installation are you running?

Home Assistant Container

Integration causing the issue

vacuum

Link to integration documentation on our website

https://www.home-assistant.io/integrations/xiaomi_miio/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

[homeassistant.components.vacuum] Error while setting up xiaomi_miio platform for vacuum
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/src/homeassistant/homeassistant/components/xiaomi_miio/vacuum.py", line 110, in async_setup_entry
    hass.data[DOMAIN][config_entry.entry_id][KEY_DEVICE],
KeyError: '54512bfa9457aca0c51ee3b92bb10313'

Additional information

No response

[probot-home-assistant]

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this issue as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

---

xiaomi_miio documentation
xiaomi_miio source
_{^{(message by IssueLinks)}}

[enkama]

Also this:

[homeassistant.components.sensor] Error while setting up xiaomi_miio platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/usr/src/homeassistant/homeassistant/components/xiaomi_miio/sensor.py", line 603, in async_setup_entry
    device = hass.data[DOMAIN][config_entry.entry_id][KEY_DEVICE]
KeyError: '54512bfa9457aca0c51ee3b92bb10313'

[hmmbob]

Tagging @OGKevin as well, as this is a regression probably caused by #54990

[OGKevin]

acked, looking.

[OGKevin]

ah, i think its because of this https://github.com/OGKevin/core/blob/e34aed743cf1a1448166a990bfdeefd654f0a452/homeassistant/components/xiaomi_miio/const.py#L198 that is used here https://github.com/OGKevin/core/blob/276345e20a8c6a68d8be2062f2a7d6b19b2ea021/homeassistant/components/xiaomi_miio/__init__.py#L282 to determine if the coordinator should be created or not.

S5 max is not in this list. So the coordinator is never created.

Now i wonder how @frenck got his S5 max working: #57474 (comment)

I'll make a PR adding S5 max to the list and see if my suspicion is indeed correct.

However, S5 max is creating a few sensors that are unsupported. That will be fixed once #57474 (comment) is resolved.

[pdobrien3]

I am also seeing this on the S4. I spun up the beta last night on a test machine and noticed it. Because it was reported already I didn’t think much to check the logs. After reading this today, I may need to add my error message.

[pdobrien3]

Unsupported device found! Please create an issue at https://github.com/syssi/xiaomi_airpurifier/issues and provide the following data: roborock.vacuum.s4. Seems to be similar to the S5 issue though ;-)

[OGKevin]

@Wibias can you try again and report back plz.

[OGKevin]

@pdobrien3 just to confirm for my PR, the roborock.vacuum.s4 does not have a mop right?

[OGKevin]

Can someone with the power to reopen this issue do it plz for the s4 🙏🏾 and until there is confirmation that its fixed. Did not expect the PR to get merged before confirmation :D.

[enkama]

@Wibias can you try again and report back plz.

I can try as soon as the new beta or a new dev is out!

[pdobrien3]

@pdobrien3 just to confirm for my PR, the roborock.vacuum.s4 does not have a mop right?

Correct. No mop on the S4

[enkama]

@OGKevin Yup, 2021.11.0b1 fixed it. Now its just the #57474 error messages! Thanks!

[hmmbob]

Confirmed fixed for my S5 MAX as well, indeed also getting the Could not determine how to parse state value of type <class 'NoneType'> for state <class 'miio.vacuumcontainers.VacuumStatus'> and attribute is_water_shortage error printed every 15sec

[coolguymatt]

I am getting this error for my Xiaowa E2 vacuum. Should I open a new issue?

Unsupported device found! Please create an issue at https://github.com/syssi/xiaomi_airpurifier/issues and provide the following data: roborock.vacuum.e2

[OGKevin]

Nah, I'll add that model to the list tomo/later tonight 👍🏾

[brendann993]

Hey @OGKevin Roborock S6 Pure is another vacuum which was working prior to the update but now reports the “unsupported model” I’ve tested adding a const for it which appears to work if we can get it added properly. It’s roborock.vacuum.a08
While it does have a mop I don’t think it has sensors for the mop as it always returns false for me. Thanks

[OGKevin]

While it does have a mop I don’t think it has sensors for the mop as it always returns false for me

We can have a look at that after the release. Feel free to create a new issue for that.