Bump broadlink from 0.16.0 to 0.17.0 #47779

felipediel · 2021-03-11T22:09:30Z

Proposed change

Bump broadlink from 0.16.0 to 0.17.0.

This version has a lot of bug fixes. It also introduces new device types, improves duck typing and adds support for monitoring energy with the new sp2s and sp4b classes.

Changelog:

Bump cryptography from 2.6.1 to 3.2
Improve exceptions
Improve repr(device) and str(device)
Reset connection ID and AES key before sending Client Key Exchange packets
Add a method to update device name and lock status
Split the rm class into rmmini and rmpro classes
Split the rm4 class into rmminib, rm4mini and rm4pro classes
Split the sp2 class into sp2, sp2s, sp3 and sp3s classes
Add a function to send ping packets
Refactor the lb1 class
Fix encryption errors
Filter unsupported features and convert sensor data to float in the sp4b class
Improve rm4 communication: prefix the payload to its length before encryption, slice accordingly after decryption and fix find_rf_packet()
Fix issue of long codes being reinterpreted by the device
Add new product ids

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes broadlink integration error #40191 fixes rm4 pro cannot be added to broadlink integration (Unsupported device: 0x653c.) #42983 fixes Broadlink. RF. [Errno -4000] Network timeout Failed to send an other #43347 fixes Broadlink RM-PRO. Repeating RF command many times. #43389 fixes Broadlink RM mini3 cant integrate, device not supported #43567 fixes SP4L-UK broadlink smart plug Unsupported device: 0xa589 #44120 fixes SP2-UK broadlink smart plug Unsupported device: 0x51e2 #44216 fixes SP4L-AU broadlink smart plug Unsupported device: 0x6489 #44530 fixes Broadlink RM4C (0x6539) mini support #45320 fixes Broadlink rm4c mini stopped working after update #45702 fixes [Broadlink] no attribute 'startswith' #45344 fixes Unsupported device: 0x653c. Broadlin #45887 fixes Integration RM4C mini #45909 fixes RM4C mini not supported in Homeassistant 2021.2.2 #46435 fixes SP4L-EU broadlink smart plug Unsupported device: 0x618b #46485 fixes Broadlink RM4 mini unsupported with new firmware #46476 fixes Error setting up entry Broadlink for broadlink #47694
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

felipediel · 2021-03-12T10:17:38Z

Thank you!

XxCabbyoO · 2021-03-12T16:55:32Z

Thank you!

Thank you felipediel for your great Work on 0.17.0 👍

I have been waiting for this for several months now to finally be able to use my RM4 C Mini with Homeassistant. 💯

felipediel · 2021-03-12T20:09:38Z

You're welcome!

XxCabbyoO · 2021-03-13T10:39:02Z

You're welcome!

will it be delivered in milestone 2021.3.5, or only in 2021.4?

felipediel · 2021-03-13T10:53:47Z

This is always a mystery. Follow the release notes to stay up to date.

XxCabbyoO · 2021-03-13T11:06:00Z

This is always a mystery. Follow the release notes to stay up to date.

Can't you even just assign it to milestone 2021.3.5 yourself? I am unfortunately a beginner, but had seen this so with other requests.

https://github.com/home-assistant/core/milestone/390

--
if not no problem, of course I can wait ;)

felipediel · 2021-03-13T11:51:34Z

Nope, I don't have privileges for that, but I am sure that those responsible will endeavor to release it soon. baloob reviewed and merged the PR in record time, this is a good sign.

ngohaiitdog · 2021-03-13T16:28:40Z

Thanks so much @felipediel for your contribution !!! Been waiting for it to make my RM4S Mini work!

felipediel · 2021-03-13T21:08:19Z

You're welcome!

nogueirasa · 2021-03-14T00:00:03Z

The problem

Trying to integrate RM4C mini came with firmware version V52078 but produces the error "Unsupported device: 0x6539"

What is version of Home Assistant Core has the issue?

2021.3.4

What type of installation are you running?

Home Assistant Docker

Integration causing the issue

Broadlink

nogueirasa · 2021-03-14T00:02:24Z

The problem

Trying to integrate RM4C mini came with firmware version V52078 but produces the error "Unsupported device: 0x6539"

What is version of Home Assistant Core has the issue?

2021.3.4

What type of installation are you running?

Home Assistant Docker

Integration causing the issue

Broadlink

@felipediel , I installed 0.17.0 with the command bellow, but continuos with the same problem.

docker exec -it homeassistant /bin/bash
pip3 install --upgrade git+https://github.com/mjg59/python-broadlink.git --no-deps

Thanks,

felipediel · 2021-03-14T00:14:09Z

@nogueirasa You shouldn't patch with v0.17.0 directly, it comes with several breaking changes. You need the code I wrote here to make it work correctly. It won't take long, but if you're in a hurry you can take my master branch.

Open Home Assistant and install "SSH & Web Terminal" add-on
Disable Protection mode
Click "Terminal" on the sidebar and install the patch.

docker exec -it homeassistant /bin/bash
pip3 install git+https://github.com/felipediel/python-broadlink.git --force-reinstall --no-deps

Restart the server.

You need to repeat the process when you update Home Assistant. The patch is not persistent.

nogueirasa · 2021-03-14T00:30:06Z

@nogueirasa You shouldn't patch with v0.17.0 directly, it comes with several breaking changes. You need the code I wrote here to make it work correctly. It won't take long, but if you're in a hurry you can take my master branch.

Open Home Assistant and install "SSH & Web Terminal" add-on

Disable Protection mode

Click "Terminal" on the sidebar and install the patch.
docker exec -it homeassistant /bin/bash
pip3 install git+https://github.com/felipediel/python-broadlink.git --force-reinstall --no-deps
Restart the server.

You need to repeat the process when you update Home Assistant. The patch is not persistent.

Working.

Home Assistant Version: core-2021.3.4
Installation Type: Home Assistant Container

Device: Broadlink (BestCon) RM4C Mini
Firmware version: v52078

Thanks @felipediel

felipediel · 2021-03-14T00:33:47Z

You're welcome!

Improve support for Broadlink switches

a3599df

homeassistant added the cla-signed label Mar 11, 2021

probot-home-assistant bot added dependency has-tests integration: broadlink labels Mar 11, 2021

probot-home-assistant bot assigned Danielhiversen Mar 11, 2021

probot-home-assistant bot added the by-code-owner label Mar 11, 2021

felipediel added 2 commits March 11, 2021 21:32

Improve support for Broadlink remotes

2a8292a

Bump broadlink from 0.16.0 to 0.17.0

41699e1

felipediel force-pushed the 0.17.0 branch from f84b41a to 41699e1 Compare March 12, 2021 00:33

balloob merged commit 9ca0cd5 into home-assistant:dev Mar 12, 2021

github-actions bot locked and limited conversation to collaborators Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump broadlink from 0.16.0 to 0.17.0 #47779

Bump broadlink from 0.16.0 to 0.17.0 #47779

felipediel commented Mar 11, 2021 •

edited

Loading

felipediel commented Mar 12, 2021

XxCabbyoO commented Mar 12, 2021

felipediel commented Mar 12, 2021 •

edited

Loading

XxCabbyoO commented Mar 13, 2021

felipediel commented Mar 13, 2021

XxCabbyoO commented Mar 13, 2021 •

edited

Loading

felipediel commented Mar 13, 2021

ngohaiitdog commented Mar 13, 2021

felipediel commented Mar 13, 2021

nogueirasa commented Mar 14, 2021

nogueirasa commented Mar 14, 2021 •

edited

Loading

felipediel commented Mar 14, 2021 •

edited

Loading

nogueirasa commented Mar 14, 2021

felipediel commented Mar 14, 2021

Bump broadlink from 0.16.0 to 0.17.0 #47779

Bump broadlink from 0.16.0 to 0.17.0 #47779

Conversation

felipediel commented Mar 11, 2021 • edited Loading

Proposed change

Changelog:

Type of change

Additional information

Checklist

felipediel commented Mar 12, 2021

XxCabbyoO commented Mar 12, 2021

felipediel commented Mar 12, 2021 • edited Loading

XxCabbyoO commented Mar 13, 2021

felipediel commented Mar 13, 2021

XxCabbyoO commented Mar 13, 2021 • edited Loading

felipediel commented Mar 13, 2021

ngohaiitdog commented Mar 13, 2021

felipediel commented Mar 13, 2021

nogueirasa commented Mar 14, 2021

nogueirasa commented Mar 14, 2021 • edited Loading

felipediel commented Mar 14, 2021 • edited Loading

nogueirasa commented Mar 14, 2021

felipediel commented Mar 14, 2021

felipediel commented Mar 11, 2021 •

edited

Loading

felipediel commented Mar 12, 2021 •

edited

Loading

XxCabbyoO commented Mar 13, 2021 •

edited

Loading

nogueirasa commented Mar 14, 2021 •

edited

Loading

felipediel commented Mar 14, 2021 •

edited

Loading