-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extra js modules to be included in frontend #24675
Allow extra js modules to be included in frontend #24675
Conversation
Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
Please add a PR for the docs 👍 |
Will do! |
home-assistant/home-assistant.io#9674 |
* Add extra_module_url and extra_module_url_es5 to frontend options * Address review comments
Description:
HTML imports are being deprecated, and the recommended way forward is to use js module imports instead. This allows specifying modules that will be imported in the frontend.
A use case may be adding aditional icon sets. This could be done using lovelace modules, but then the new icons would work only after loading the lovelace panel. I.e. in a browser opened directly to e.g.
/states
or/config/entity_registry
the new icons wouldn't show up.Corresponding frontend PR: home-assistant/frontend#3288
(Quick and dirty WIP/POC)
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9674
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: