Remove compatibility with core without frontend.add_extra_js_url

[emontnemery]

Remove compatibility with core without frontend.add_extra_js_url

Rationale:
frontend.add_extra_js_url was added 5 years ago in PR home-assistant/core#24675

[ludeeus]

The reason this is here is because nothing in core is using it, so there is a high chance it will just be removed.

[ludeeus]

#3447

[coderabbitai]

Walkthrough

Walkthrough

The custom_components/hacs/frontend.py file has been modified to directly import the add_extra_js_url function instead of using a try-except block for the import. This refactoring enhances the code's readability and maintainability by making the imported modules explicit and removing unnecessary exception handling for the import process.

Changes

Files	Change Summary
custom_components/hacs/frontend.py	Refactored to import add_extra_js_url directly, eliminating the try-except block for the import.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between f4a65c1 and 9eb980b.

Files selected for processing (1)

• custom_components/hacs/frontend.py (1 hunks)

Additional comments not posted (1)

custom_components/hacs/frontend.py (1)

8-11: The import changes streamline the module imports by removing the previous try-except block.

This change enhances readability and maintainability as it assumes the presence of add_extra_js_url, which has been part of Home Assistant for over five years. Ensure that this assumption is safe across all supported versions of Home Assistant to avoid runtime errors.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range comments (3)

custom_components/hacs/frontend.py (3)

Line range hint 21-23: Ensure that the warning about running in development mode is clear to the user. It might be beneficial to log this at a higher severity than warning if it should never occur in production.

Consider changing the log level to error to emphasize the importance of not using development mode in production environments.

---

Line range hint 33-42: The registration of the custom panel and iconset uses hardcoded paths and configurations. This is generally fine, but consider making these values configurable through environment variables or configuration files for greater flexibility.

Introducing configuration options for these paths and icons could improve the adaptability of this integration in different environments.

---

Line range hint 44-44: The setup for the frontend endpoint plugin is asynchronous but does not handle potential exceptions. Consider adding error handling to ensure robustness.

- await hacs.async_setup_frontend_endpoint_plugin()
+ try:
+     await hacs.async_setup_frontend_endpoint_plugin()
+ except Exception as e:
+     hacs.log.error(f"Failed to setup frontend endpoint plugin: {str(e)}")