Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer binary with wheels #24669

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Prefer binary with wheels #24669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/util/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def install_package(package: str, upgrade: bool = True,
if constraints is not None:
args += ['--constraint', constraints]
if find_links is not None:
args += ['--find-links', find_links]
args += ['--find-links', find_links, '--prefer-binary']
if target:
assert not is_virtual_env()
# This only works if not running in venv
Expand Down
2 changes: 1 addition & 1 deletion tests/util/test_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_install_find_links(mock_sys, mock_popen, mock_env_copy, mock_venv):
mock_popen.call_args ==
call([
mock_sys.executable, '-m', 'pip', 'install', '--quiet',
TEST_NEW_REQ, '--find-links', link
TEST_NEW_REQ, '--find-links', link, '--prefer-binary'
], stdin=PIPE, stdout=PIPE, stderr=PIPE, env=env)
)
assert mock_popen.return_value.communicate.call_count == 1
Expand Down