Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer binary with wheels #24669

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Prefer binary with wheels #24669

merged 1 commit into from
Jun 21, 2019

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 21, 2019

Description:

If there is a wheels repository added, it should be prefer use this for binary.

@pvizeli pvizeli added this to the 0.95.0 milestone Jun 21, 2019
@pvizeli pvizeli requested a review from a team as a code owner June 21, 2019 08:23
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Jun 21, 2019
@pvizeli pvizeli changed the title Prefere binary with wheels Prefer binary with wheels Jun 21, 2019
@frenck
Copy link
Member

frenck commented Jun 21, 2019

This also prefers binary in a way that it is getting older versions of a package if the newer version isn't available as a binary... is that wished for?

@pvizeli
Copy link
Member Author

pvizeli commented Jun 21, 2019

Yes, because we have all binary available and freeze on image. Custom components can work with source/binary too or use our service they we provide for public custom components. We speak about the Hass.io images and later with manifest they allow to set this URL too.

@home-assistant home-assistant deleted a comment Jun 21, 2019
@balloob balloob merged commit c9453ba into dev Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the prefere-binary branch June 21, 2019 15:48
balloob pushed a commit that referenced this pull request Jun 21, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants