Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attribute lowBat for Homematic IP devices #24323

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Remove attribute lowBat for Homematic IP devices #24323

merged 1 commit into from
Jun 6, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Jun 5, 2019

Breaking Change:

The lowBat attribute has been removed from HmIP Devices.
Please use the battery binary_sensor (since 0.92.0) instead.

Description:

The low_bat attribute of HmIP devices has been replaced by a battery sensor with HA 0.92.0.
The low_bat attribute is only needed for SecurityGroups.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

Copy link
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you making these changes? Is the battery level not an attribute of the device? Users can always create a sensor template to represent the battery level as it's own entity.

@SukramJ
Copy link
Contributor Author

SukramJ commented Jun 5, 2019

PR #22630 already introduced a battery sensor.
This PR only removes the no longer required attribute for the devices/entity.

@andrewsayre andrewsayre merged commit 64d6fa8 into home-assistant:dev Jun 6, 2019
@SukramJ SukramJ deleted the HmIP-remove-lowBat-attr branch June 6, 2019 16:54
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants