Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add battery sensor to Homematic IP #22630

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Add battery sensor to Homematic IP #22630

merged 1 commit into from
Apr 2, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Apr 1, 2019

Description:

This PR adds a battery sensor to Homematic IP Cloud.
This PR is inspired by @balloob comment on PR #22594 about a future "devices with low battery" page.

Current existing device_state_attributes for lowBat should be removed in a future PR.

Nice side-effect: Device that where currently not supported by this integration are now visible in HA, if they are battery driven like remotes.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@balloob balloob merged commit 6c14e7a into home-assistant:dev Apr 2, 2019
@ghost ghost removed the in progress label Apr 2, 2019
@SukramJ SukramJ deleted the HmIP-LowBat branch April 2, 2019 17:47
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants