Add OnResume event to handle play status correctly #14403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: media_player.kodi
small-pr
emlove
reviewed
May 15, 2018
| @@ -392,7 +393,7 @@ def state(self): | |||
| if not self._players: | |||
| return STATE_IDLE | |||
|
|
|||
| if self._properties['speed'] == 0 and not self._properties['live']: | |||
There was a problem hiding this comment.
see related issue from description
There was a problem hiding this comment.
The problem with this is that the state will change if the stream buffers, so if you're watching something which keeps buffering it'll trigger whatever state change actions you have set (which for me is lights, which quickly becomes annoying)
houndci-bot
reviewed
May 18, 2018
| if MEDIA_TYPES.get(self._item.get('type')) is None and self._players: | ||
| return MEDIA_TYPES.get(self._players[0]['type']) | ||
| return MEDIA_TYPES.get(self._item.get('type')) | ||
| return self._item.get('title') or self._item.get('label') or self._item.get('file') |
There was a problem hiding this comment.
line too long (91 > 79 characters)
|
I added another fix to the PR. title is still present as an empty string in the response even if not set and so get() with default doesn't work. dictionary get() |
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #14394
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: