-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix climate temperature range checking does not support customization of ranges #126924
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Customize is not meant to override any behavior. All features that customize was meant to cover have been migrated to the frontend. We cannot accept this PR. |
Alot of people seem to be broken by this change. As far as I can tell there is no way to customize min or max temp from the front end. Open to other suggestions on how to fix. I believe it should be validating against the attributes in the state machine not the attributes reported by the integration. |
That is correct.
There is nothing to fix, as this is not a feature at this point. If you want to suggest a feature, you should try our Community Forum: Feature Requests. If you have additional questions, feel free to join our Discord chat server. Thanks! 👍 ../Frenck |
sounds good, was trying to help out as #123612 has been open for a month with no progress. The example using generic_thermostat may not have been optimal. lots of people customize the range of thermostats (zwave, etc.) by using these parameters as not all integrations properly report the min / max range and hence default to the defaults. Before the breaking change in #118649 - all these use cases worked - and now they are broken. |
Just because a workaround worked, doesn't make the workaround a valid solution or feature. ../Frenck |
As @PeteRager mentions, customizing max min temp has been a working solution for those thermostats not integrating properly. I've had my Honeywell T6 Zwave thermostat for 5 years w/ customized max min and have been unable to upgrade from 7.4 due to the breaking change mentioned. There are no end-user options available to fix this integration problem that affects numerous thermostats. |
@lotan80 I've understood that part, nevertheless thanks for clarifying. However, that doesn't change the already mentioned above. ../Frenck |
I think I finally understand. Took me a while :-). If the integration is reporting incorrect min and max limits for the climate entity, the fix is to update the integration to report the correct limits. So in context of @lotan80 issue with the T6 (i have 4 of these), the correct solution is to update the zwavejs integration to report the correct limits. @lotan80 - please open an issue for the zwave integration, link it here and i'll start working on it. |
Actually, for the T6 the thermostat does not report it's limits in a standard way, so there is no way for the integration to report them correctly and hence it returns the defaults. |
Proposed change
PR #118649 introduced validation of climate temperature ranges in the climate platform. Prior to this change, the limits were enforced in the UI and optionally in the integration. The climate min and max temperature ranges may be overridden using customize - this change updates the validation code to take this into account.
Here is a simple example using the generic thermostat. The min limit that should be checked should be 40.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: