-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Climate validate temperature(s) out of range #118649
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
2286066
to
95a577e
Compare
I like the goal of this PR, @gjohansson-ST 👍 It will help finding bugs and other unexpected behaviors. |
dbc1a92
to
189815c
Compare
2df0e35
to
a9d5760
Compare
Test failure is unrelated. Seems there is quite some flaky tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gjohansson-ST 👍
../Frenck
8818588
to
037beb6
Compare
Test failure ( |
), | ||
built_in=False, | ||
) | ||
mock_platform( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this helper:
Line 1737 in 6baee60
def setup_test_component_platform( |
May need to allow opt-out of this feature. See #128118 |
Proposed change
Previously the climate entity min and max temperature values was used only for frontend displaying correctly but no validation against what the user could set (if not managed by the integrations themselves).
This PR adds a validation to so if the temperature(s) sent in are less than min or more than max it will raise a validation error and not pass to the integration.
Dev docs PR: home-assistant/developers.home-assistant#2259
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: