Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Weblinks - FTP URL not allowed in 0.63 #12294

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Fix Weblinks - FTP URL not allowed in 0.63 #12294

merged 1 commit into from
Feb 11, 2018

Conversation

ReneNulschDE
Copy link
Contributor

Description:

FTP links are not allowed in 0.63. Changed code back to vol.url() test.
Additional test added.

Related issue (if applicable): fixes #12286

Example entry for configuration.yaml (if applicable):

weblink:
  entities:
    - name: IP Cam Files
      url: ftp://some/url
      icon: mdi:webcam

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@ReneNulschDE ReneNulschDE requested a review from a team as a code owner February 11, 2018 10:01
@ReneNulschDE ReneNulschDE changed the title Fix Weblinks FTP URL not allowed in 0.63 Fix Weblinks - FTP URL not allowed in 0.63 Feb 11, 2018
@balloob balloob merged commit 2edebfe into home-assistant:dev Feb 11, 2018
@ReneNulschDE ReneNulschDE deleted the Fix-Weblink branch February 11, 2018 17:29
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weblinks 'Failed config' in 0.63
3 participants