Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblinks 'Failed config' in 0.63 #12286

Closed
VDRainer opened this issue Feb 11, 2018 · 4 comments · Fixed by #12294 or #12295
Closed

Weblinks 'Failed config' in 0.63 #12286

VDRainer opened this issue Feb 11, 2018 · 4 comments · Fixed by #12294 or #12295

Comments

@VDRainer
Copy link
Contributor

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version):
0.63.0

Python release (python3 --version):
3.6.3

Component/platform:
weblinks

Description of problem:
Weblinks fail to load.

configuration.yaml

weblink:
  entities:
    - name: IP Cam Control
      url: !secret ip_cam_control
      icon: mdi:webcam
    - name: IP Cam Files
      url: !secret ip_cam_files
      icon: mdi:folder-image
    - name: RPi Cam Control
      url: !secret rpi_cam_control
      icon: mdi:webcam
    - name: Cam Keller
      url: !secret cam_keller_url
      icon: mdi:webcam
    - name: Wetter Bayern
      url: http://www.dwd.de/DE/wetter/wetterundklima_vorort/bayern/bayern_node.html
      icon: mdi:weather-snowy-rainy
    - name: HASS Configurator
      url: http://192.168.xxx.xxx:3218/
      icon: mdi:wrench

Log:

Failed config
  weblink: 
    entities: [source /home/homeassi/.homeassistant/configuration.yaml:256]
      - icon: mdi:webcam
        name: IP Cam Control
        url: http://some/url.html
      - icon: mdi:folder-image
        name: IP Cam Files
        url: ftp://some/url.html
      - icon: mdi:webcam
        name: RPi Cam Control
        url: http://some/url.html
      - icon: mdi:webcam
        name: Cam Keller
        url: http://some/url.html
      - icon: mdi:weather-snowy-rainy
        name: Wetter Bayern
        url: http://www.dwd.de/DE/wetter/wetterundklima_vorort/bayern/bayern_node.html
      - icon: mdi:wrench
        name: HASS Configurator
        url: http://192.168.xxx.xxx:3218/

  General Errors: 
    - Setup failed for weblink: Invalid config.
@RiRomain
Copy link
Contributor

Their was a change concerning weblink, so I guess it might be related:
#11808

@ReneNulschDE
Copy link
Contributor

From my perspective, the problem is the FTP link.

FTP links are not allowed based on this code

Has this worked in 0.62.x?

@VDRainer
Copy link
Contributor Author

@ReneNulschDE, yes, this has worked until 0.63 and you're right. When i remove the FTP Link it works again.
Why are ftp links not allowed?

@ReneNulschDE
Copy link
Contributor

sorry, looks like this was my mistake. I've changed the code from vol.Url() to cv.url with the latest commit. I'll create a PR to fix this.

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants