-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overkiz water targets temperature numbers for Atlantic water heater #114185
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, @Tronix117, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some small comments.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
…er (#114185) * Adds water targets temperature numbers for Atlantic water heater * Update homeassistant/components/overkiz/number.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/number.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * ruff formatting reverted * Update homeassistant/components/overkiz/number.py Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com> * Update homeassistant/components/overkiz/number.py Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com> * changed command hardcode to a constant --------- Co-authored-by: Mick Vleeshouwer <mick@imick.nl> Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Proposed change
Expands #114178, adding water targets temperature numbers for Atlantic water heater
The code was tested on Atlantic Steatite Cube WI-FI VM 150 S4CS 2400W.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: