Improve AtlanticDomesticHotWaterProductionMBLComponent support in Overkiz #114178
Conversation
Adds support of Overkiz water heater entity selection based on device controllable_name Adds support of Atlantic water heater based on Atlantic Steatite Cube WI-FI VM 150 S4CS 2400W Adds more Overkiz water heater binary_sensors, numbers, and sensors
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, @Tronix117, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks a lot for your contribution!
Please include only a single entity change per PR. Would be great if you can split up the binary_sensor, number, sensor and water_heater changes to separate PRs. The smaller PRs should get in fairly easy, the water heater might take a bit more time.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Done. Preparing separate PRs for binary_sensors, number and sensor |
Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
To be clear, we are talking about #114178 (comment) the refreshing of the sensors that do not refresh themselves too much. |
|
Hi @ALERTua , I finally managed to test it with my own Atlantic, and actually, the functions seem to work as you described in general. 
Same in app and seems to be working ok! 
However, I noticed a strange issue in the away mode that seems to cause an odd situation. When I switch from performance mode to away mode, the state information disappears completely or alternatively changes to unknown, and Home Assistant reports an error. The state does indeed change to absence mode in the app, so the away mode works in principle. After a while, the absence mode changed itself back to off mode. 
I suppose that away mode actually works but there should be different "work mode" or "off state" or "something"... |
|
yeah, about that: while in Away mode, the heater is off, but the entity does not support this state, at least I don't know how I can allow the entity to become OFF without allowing the user to try to switch the heater OFF. I don't see a problem with this, but I will accept any suggestions for improvement. |
@ALERTua , I'm quite sure that with your experience with Atlantic, this puzzle will be solved sooner or later. :-) |
|
Hi @iMicknl , I can confirm that the code works on my device as ALERTua described. |
...assistant/components/overkiz/water_heater_entities/atlantic_domestic_hot_water_production.py
Outdated
Show resolved
Hide resolved
…on change reverted
…rkiz (#114178) * add overkiz AtlanticDHW support Adds support of Overkiz water heater entity selection based on device controllable_name Adds support of Atlantic water heater based on Atlantic Steatite Cube WI-FI VM 150 S4CS 2400W Adds more Overkiz water heater binary_sensors, numbers, and sensors * Changed class annotation * min_temp and max_temp as properties * reverted binary_sensors, number, sensor to make separate PRs * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/water_heater.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * review fixes, typos, and pylint * review fix * review fix * ruff * temperature properties changed to constructor attributes * logger removed * constants usage consistency * redundant mapping removed * Update homeassistant/components/overkiz/water_heater_entities/atlantic_dhw.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * boost mode method annotation typo * removed away mode for atlantic dwh * absence and boost mode attributes now support 'prog' state * heating status bugfix * electrical consumption sensor * warm water remaining volume sensor * away mode reintroduced * mypy check * boost plus state support * Update homeassistant/components/overkiz/sensor.py Co-authored-by: Mick Vleeshouwer <mick@imick.nl> * sensors reverted to separate them into their own PR * check away and boost modes on before switching them off * atlantic_dhw renamed to atlantic_domestic_hot_water_production * annotation changed * AtlanticDomesticHotWaterProductionMBLComponent file renamed, annotation change reverted --------- Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
...onents/overkiz/water_heater_entities/atlantic_domestic_hot_water_production_mlb_component.py
Show resolved
Hide resolved
Proposed change
The code was tested on Atlantic Steatite Cube WI-FI VM 150 S4CS 2400W.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: