Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for updating ble transmitter measured power #1086

Merged

Conversation

dshokouhi
Copy link
Member

@jpelgrom
Copy link
Member

jpelgrom commented Aug 6, 2024

This section is getting a lot of examples, I'm wondering if perhaps adding things to a list/table like above would be better. Did you consider this?

@dshokouhi
Copy link
Member Author

This section is getting a lot of examples, I'm wondering if perhaps adding things to a list/table like above would be better. Did you consider this?

yea a table does not make much sense here because we can only update 1 item at a time, only measured power can be updated and a separate command needs to be sent to turn off teh transmitter or adjust the advertise mode etc...

@jpelgrom
Copy link
Member

jpelgrom commented Aug 6, 2024

I suppose that is true. Let's save the discussion about the number of examples in the documentation for another time ;)

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when Android PR is merged

@dshokouhi dshokouhi merged commit 847c8a9 into home-assistant:master Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants