Allow measured power to be updated via notification command

[dshokouhi]

Summary

Implements: #3290

example service call:

service: notify.mobile_app_pixel_8_pro
data:
  message: command_ble_transmitter
  data:
    command: ble_set_measured_power
    ble_measured_power: "-10"

The field is validated that its not blank and that it is a negative number

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#1086

Any other notes

FCM PR: home-assistant/mobile-apps-fcm-push#150

[jpelgrom]

in some cases the notification will post on the device, in other cases the setting may revert to default

Why have it behave differently, instead of always ignoring it (which is the default behavior with notification commands for invalid values)?

[dshokouhi]

in some cases the notification will post on the device, in other cases the setting may revert to default

Why have it behave differently, instead of always ignoring it (which is the default behavior with notification commands for invalid values)?

Added a check to make sure that doesn't happen, should be good now :)

[jpelgrom]

I'm not sure I follow.

(data[DeviceCommandData.BLE_MEASURED_POWER]?.toIntOrNull() ?: BluetoothSensorManager.DEFAULT_MEASURED_POWER_AT_1M) < 0

will still use a different value if it cannot be parsed to an int, instead of rejecting/ignoring the command.

[dshokouhi]

That was why i added the check before to capture any other bad value, added toIntOrNull because wanted to avoid a crash. I tested with teh following

• negative numbers - works
• positive numbers - posts notification
• alphanumeric - posts notification
• blank - posts notification

[jpelgrom]

But why not do toIntOrNull() != null before instead of this convoluted check? The orNull is literally there for bad values.

And even if there is a bad (positive) value, it is still set as you don't change the value in line 160?

data[NotificationData.COMMAND] == DeviceCommandData.BLE_SET_MEASURED_POWER &&
    (
        data[DeviceCommandData.BLE_MEASURED_POWER].toIntOrNull() != null && data[DeviceCommandData.BLE_MEASURED_POWER]?.toInt() < 0
        )

[jpelgrom]

I see my comment is inconsistent with current behavior - invalid changed to something valid for UUID/major/minor.

android/common/src/main/java/io/homeassistant/companion/android/common/notifications/DeviceCommands.kt

Lines 144 to 145 in 485a842

	DeviceCommandData.BLE_SET_MAJOR -> data[DeviceCommandData.BLE_MAJOR]
	?: BluetoothSensorManager.DEFAULT_BLE_MAJOR

But that is the exception to the default which ignores the command if invalid (in check):

android/common/src/main/java/io/homeassistant/companion/android/common/notifications/DeviceCommands.kt

Line 68 in 485a842

(!data[DeviceCommandData.BLE_ADVERTISE].isNullOrEmpty() && data[DeviceCommandData.BLE_ADVERTISE] in DeviceCommandData.BLE_ADVERTISE_COMMANDS) ||

[dshokouhi]

Your check is simpler and for some reason I did not consider it, lets go with that as its easier to read :)